Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2192783002: Parse PopularSites JSON by callback. (Closed)

Created:
4 years, 4 months ago by sfiera
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@json
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse PopularSites JSON by callback. Pass safe_json::SafeJsonParser::Parse in from MostVisitedSitesBridge and remove the dep on safe_json from ntp_tiles. BUG=617966 Committed: https://crrev.com/401656d055069eb000bc1f2b42cf499cf29c3884 Cr-Commit-Position: refs/heads/master@{#408377}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/popular_sites_internals_message_handler.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M components/ntp_tiles.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/ntp_tiles/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M components/ntp_tiles/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_tiles/popular_sites.h View 3 chunks +8 lines, -1 line 0 comments Download
M components/ntp_tiles/popular_sites.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
sfiera
Next step after http://crrev.com/2179233003
4 years, 4 months ago (2016-07-28 09:05:49 UTC) #2
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-07-28 11:34:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192783002/40001
4 years, 4 months ago (2016-07-28 11:40:34 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 12:37:05 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 12:39:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/401656d055069eb000bc1f2b42cf499cf29c3884
Cr-Commit-Position: refs/heads/master@{#408377}

Powered by Google App Engine
This is Rietveld 408576698