chrome/browser/android/ntp/most_visited_sites_bridge.cc - Issue 2192783002: Parse PopularSites JSON by callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/most_visited_sites_bridge.cc

Issue 2192783002: Parse PopularSites JSON by callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@json

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/ntp/most_visited_sites_bridge.cc

diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.cc b/chrome/browser/android/ntp/most_visited_sites_bridge.cc

index 75d03ff9410f3531e2682d06eac232d589cc41f2..d8bfe17b061fb8342c3fe8e27b3f613e1c01b02e 100644

--- a/chrome/browser/android/ntp/most_visited_sites_bridge.cc

+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.cc

@@ -25,6 +25,7 @@

#include "chrome/browser/thumbnails/thumbnail_list_source.h"

#include "components/history/core/browser/top_sites.h"

#include "components/ntp_tiles/popular_sites.h"

+#include "components/safe_json/safe_json_parser.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/url_data_source.h"

#include "jni/MostVisitedSites_jni.h"

@@ -162,7 +163,8 @@ MostVisitedSitesBridge::MostVisitedSitesBridge(Profile* profile)

TemplateURLServiceFactory::GetForProfile(profile),

g_browser_process->variations_service(),

profile->GetRequestContext(),

- ChromePopularSites::GetDirectory()),

+ ChromePopularSites::GetDirectory(),

+ base::Bind(safe_json::SafeJsonParser::Parse)),

most_visited_(BrowserThread::GetBlockingPool(),

profile->GetPrefs(),

TopSitesFactory::GetForProfile(profile),

« no previous file with comments | « no previous file | chrome/browser/ui/webui/popular_sites_internals_message_handler.cc » ('j') | no next file with comments »