Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2192543003: Add //components/ntp_tiles/ to iOS build. (Closed)

Created:
4 years, 4 months ago by sfiera
Modified:
4 years, 4 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@json2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //components/ntp_tiles/ to iOS build. BUG=617966 Committed: https://crrev.com/ff9d227b16b1f6d34677c0bfe19153526c7bbfa7 Cr-Commit-Position: refs/heads/master@{#409153}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/BUILD.gn View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 4 4 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
sfiera
Ready to start work on using this in iOS, finally. The blocking dependencies have been ...
4 years, 4 months ago (2016-08-01 08:44:09 UTC) #12
sdefresne
lgtm
4 years, 4 months ago (2016-08-02 05:23:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192543003/80001
4 years, 4 months ago (2016-08-02 07:57:02 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-02 08:00:08 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 08:01:27 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ff9d227b16b1f6d34677c0bfe19153526c7bbfa7
Cr-Commit-Position: refs/heads/master@{#409153}

Powered by Google App Engine
This is Rietveld 408576698