Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2192643002: Make sure PDB files are in runtime_deps for GN builds. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure PDB files are in runtime_deps for GN builds. Before r407890, we had no good way to make sure that we were including the .pdb files for executables and shared libraries in the runtime_deps for a target. Now that GN has a `runtime_outputs` option, we can use that and list the PDBs. This should fix issues for debugging and also packaging the NaCl files as part of an official build. R=brettw@chromium.org, sebmarchand@chromium.org BUG=624478, 629709 Committed: https://crrev.com/f79ed9d194a29309f5e6e9a680295459114cbfe4 Cr-Commit-Position: refs/heads/master@{#408282}

Patch Set 1 #

Patch Set 2 : we generate pdbs even when symbol_level==1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M build/toolchain/win/BUILD.gn View 1 6 chunks +22 lines, -5 lines 0 comments Download
M components/nacl/broker/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-27 22:24:44 UTC) #1
brettw
lgtm
4 years, 4 months ago (2016-07-27 22:51:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192643002/20001
4 years, 4 months ago (2016-07-27 22:56:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 23:59:48 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 00:02:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f79ed9d194a29309f5e6e9a680295459114cbfe4
Cr-Commit-Position: refs/heads/master@{#408282}

Powered by Google App Engine
This is Rietveld 408576698