Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: components/nacl/broker/BUILD.gn

Issue 2192643002: Make sure PDB files are in runtime_deps for GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: we generate pdbs even when symbol_level==1 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/broker/BUILD.gn
diff --git a/components/nacl/broker/BUILD.gn b/components/nacl/broker/BUILD.gn
index a2fa9a670dbf73e3cdafdaee538a42f045c06427..c7d36f6607e00a4e523ff152ee356038894c74fc 100644
--- a/components/nacl/broker/BUILD.gn
+++ b/components/nacl/broker/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/config/features.gni")
+import("//build/config/compiler/compiler.gni")
# This file builds nacl64.exe, which is a 64-bit x86 Windows executable
# used only in the 32-bit x86 Windows build. The :broker code runs both
@@ -67,6 +68,9 @@ if (current_cpu == "x86") {
sources = [
"$nacl64_out_dir/nacl64.exe",
]
+ if (symbol_level != 0) {
+ sources += [ "$nacl64_out_dir/nacl64.exe.pdb" ]
+ }
outputs = [
"$root_out_dir/{{source_file_part}}",
]
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698