Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: components/nacl/broker/BUILD.gn

Issue 2192643002: Make sure PDB files are in runtime_deps for GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: we generate pdbs even when symbol_level==1 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/compiler/compiler.gni")
6 7
7 # This file builds nacl64.exe, which is a 64-bit x86 Windows executable 8 # This file builds nacl64.exe, which is a 64-bit x86 Windows executable
8 # used only in the 32-bit x86 Windows build. The :broker code runs both 9 # used only in the 32-bit x86 Windows build. The :broker code runs both
9 # in nacl64.exe and in the 32-bit chrome executable, to launch 10 # in nacl64.exe and in the 32-bit chrome executable, to launch
10 # nacl64.exe and communicate with it. 11 # nacl64.exe and communicate with it.
11 12
12 assert(enable_nacl) 13 assert(enable_nacl)
13 assert(is_win) 14 assert(is_win)
14 assert(target_cpu == "x86") 15 assert(target_cpu == "x86")
15 16
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 if (is_clang) { 61 if (is_clang) {
61 x64_toolchain = "//build/toolchain/win:clang_nacl_win64" 62 x64_toolchain = "//build/toolchain/win:clang_nacl_win64"
62 } else { 63 } else {
63 x64_toolchain = "//build/toolchain/win:nacl_win64" 64 x64_toolchain = "//build/toolchain/win:nacl_win64"
64 } 65 }
65 nacl64_label = ":nacl64($x64_toolchain)" 66 nacl64_label = ":nacl64($x64_toolchain)"
66 nacl64_out_dir = get_label_info(nacl64_label, "root_out_dir") 67 nacl64_out_dir = get_label_info(nacl64_label, "root_out_dir")
67 sources = [ 68 sources = [
68 "$nacl64_out_dir/nacl64.exe", 69 "$nacl64_out_dir/nacl64.exe",
69 ] 70 ]
71 if (symbol_level != 0) {
72 sources += [ "$nacl64_out_dir/nacl64.exe.pdb" ]
73 }
70 outputs = [ 74 outputs = [
71 "$root_out_dir/{{source_file_part}}", 75 "$root_out_dir/{{source_file_part}}",
72 ] 76 ]
73 deps = [ 77 deps = [
74 nacl64_label, 78 nacl64_label,
75 ] 79 ]
76 } 80 }
77 } else if (current_cpu == "x64") { 81 } else if (current_cpu == "x64") {
78 # In the x64 toolchain context, build nacl64.exe for real. 82 # In the x64 toolchain context, build nacl64.exe for real.
79 executable("nacl64") { 83 executable("nacl64") {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 "//chrome/installer/util:with_no_strings", 159 "//chrome/installer/util:with_no_strings",
156 "//components/browser_watcher:browser_watcher_client", 160 "//components/browser_watcher:browser_watcher_client",
157 "//components/flags_ui:switches", 161 "//components/flags_ui:switches",
158 "//components/policy", 162 "//components/policy",
159 "//content/public/common:static_switches", 163 "//content/public/common:static_switches",
160 "//ipc", 164 "//ipc",
161 "//third_party/kasko", 165 "//third_party/kasko",
162 ] 166 ]
163 } 167 }
164 } 168 }
OLDNEW
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698