Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2192503002: [ios] Cleaned up UIWebView workarounds from window_id.js. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Cleaned up UIWebView workarounds from window_id.js. 1.) Delaying queues flushing is unnecessary because reentrace can't happen with asynchronous JS API. 2.) Check for message object presence is unnecessary because it is injected together with __crWeb object. BUG=402682, 628832 Committed: https://crrev.com/cfa709c1f383195a9e134e4d86fd7664272a2783 Cr-Commit-Position: refs/heads/master@{#408250}

Patch Set 1 #

Patch Set 2 : Fixed tests #

Total comments: 2

Patch Set 3 : s/CRWJSWindowIdManager/CRWJSWindowIDManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M ios/web/web_state/js/crw_js_window_id_manager_unittest.mm View 1 5 chunks +5 lines, -4 lines 0 comments Download
M ios/web/web_state/js/resources/window_id.js View 1 2 1 chunk +3 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-07-27 18:49:04 UTC) #11
kkhorimoto
lgtm with nit https://codereview.chromium.org/2192503002/diff/20001/ios/web/web_state/js/resources/window_id.js File ios/web/web_state/js/resources/window_id.js (right): https://codereview.chromium.org/2192503002/diff/20001/ios/web/web_state/js/resources/window_id.js#newcode15 ios/web/web_state/js/resources/window_id.js:15: // CRWJSWindowIdManager replaces $(WINDOW_ID) with appropriate ...
4 years, 4 months ago (2016-07-27 20:44:49 UTC) #12
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2192503002/diff/20001/ios/web/web_state/js/resources/window_id.js File ios/web/web_state/js/resources/window_id.js (right): https://codereview.chromium.org/2192503002/diff/20001/ios/web/web_state/js/resources/window_id.js#newcode15 ios/web/web_state/js/resources/window_id.js:15: // CRWJSWindowIdManager replaces $(WINDOW_ID) with appropriate string upon ...
4 years, 4 months ago (2016-07-27 20:51:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192503002/40001
4 years, 4 months ago (2016-07-27 20:51:53 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-27 21:57:11 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 22:00:10 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cfa709c1f383195a9e134e4d86fd7664272a2783
Cr-Commit-Position: refs/heads/master@{#408250}

Powered by Google App Engine
This is Rietveld 408576698