Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: ios/web/web_state/js/crw_js_window_id_manager_unittest.mm

Issue 2192503002: [ios] Cleaned up UIWebView workarounds from window_id.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/CRWJSWindowIdManager/CRWJSWindowIDManager Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/web/web_state/js/resources/window_id.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/web_state/js/crw_js_window_id_manager.h" 5 #import "ios/web/web_state/js/crw_js_window_id_manager.h"
6 6
7 #import <WebKit/WebKit.h> 7 #import <WebKit/WebKit.h>
8 8
9 #import "ios/web/public/test/js_test_util.h" 9 #import "ios/web/public/test/js_test_util.h"
10 #import "ios/web/web_state/js/page_script_util.h"
10 #import "testing/gtest_mac.h" 11 #import "testing/gtest_mac.h"
11 12
12 namespace web { 13 namespace web {
13 14
14 // Tests that window ID injection by a second manager results in a different 15 // Tests that window ID injection by a second manager results in a different
15 // window ID. 16 // window ID.
16 TEST(JSWindowIDManagerTest, WindowIDDifferentManager) { 17 TEST(JSWindowIDManagerTest, WindowIDDifferentManager) {
17 // Inject the first manager. 18 // Inject the first manager.
18 WKWebView* web_view = [[[WKWebView alloc] init] autorelease]; 19 WKWebView* web_view = [[[WKWebView alloc] init] autorelease];
19 EvaluateJavaScript(web_view, @"window.__gCrWeb = {};"); 20 EvaluateJavaScript(web_view, GetEarlyPageScript());
20 21
21 CRWJSWindowIDManager* manager = 22 CRWJSWindowIDManager* manager =
22 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view] autorelease]; 23 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view] autorelease];
23 [manager inject]; 24 [manager inject];
24 EXPECT_NSEQ([manager windowID], 25 EXPECT_NSEQ([manager windowID],
25 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId")); 26 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId"));
26 27
27 // Inject the second manager. 28 // Inject the second manager.
28 WKWebView* web_view2 = [[[WKWebView alloc] init] autorelease]; 29 WKWebView* web_view2 = [[[WKWebView alloc] init] autorelease];
29 EvaluateJavaScript(web_view2, @"window.__gCrWeb = {};"); 30 EvaluateJavaScript(web_view2, GetEarlyPageScript());
30 31
31 CRWJSWindowIDManager* manager2 = 32 CRWJSWindowIDManager* manager2 =
32 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view2] autorelease]; 33 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view2] autorelease];
33 [manager2 inject]; 34 [manager2 inject];
34 EXPECT_NSEQ([manager2 windowID], 35 EXPECT_NSEQ([manager2 windowID],
35 EvaluateJavaScript(web_view2, @"window.__gCrWeb.windowId")); 36 EvaluateJavaScript(web_view2, @"window.__gCrWeb.windowId"));
36 37
37 // Window IDs must be different. 38 // Window IDs must be different.
38 EXPECT_NSNE([manager windowID], [manager2 windowID]); 39 EXPECT_NSNE([manager windowID], [manager2 windowID]);
39 } 40 }
40 41
41 // Tests that injecting multiple times creates a new window ID. 42 // Tests that injecting multiple times creates a new window ID.
42 TEST(JSWindowIDManagerTest, MultipleInjections) { 43 TEST(JSWindowIDManagerTest, MultipleInjections) {
43 WKWebView* web_view = [[[WKWebView alloc] init] autorelease]; 44 WKWebView* web_view = [[[WKWebView alloc] init] autorelease];
44 EvaluateJavaScript(web_view, @"window.__gCrWeb = {};"); 45 EvaluateJavaScript(web_view, GetEarlyPageScript());
45 46
46 // First injection. 47 // First injection.
47 CRWJSWindowIDManager* manager = 48 CRWJSWindowIDManager* manager =
48 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view] autorelease]; 49 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view] autorelease];
49 [manager inject]; 50 [manager inject];
50 NSString* windowID = [manager windowID]; 51 NSString* windowID = [manager windowID];
51 EXPECT_NSEQ(windowID, 52 EXPECT_NSEQ(windowID,
52 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId")); 53 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId"));
53 54
54 // Second injection. 55 // Second injection.
55 [manager inject]; 56 [manager inject];
56 EXPECT_NSEQ([manager windowID], 57 EXPECT_NSEQ([manager windowID],
57 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId")); 58 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId"));
58 59
59 EXPECT_NSNE(windowID, [manager windowID]); 60 EXPECT_NSNE(windowID, [manager windowID]);
60 } 61 }
61 62
62 // Tests that injection will retry if |window.__gCrWeb| is not present. 63 // Tests that injection will retry if |window.__gCrWeb| is not present.
63 TEST(JSWindowIDManagerTest, InjectionRetry) { 64 TEST(JSWindowIDManagerTest, InjectionRetry) {
64 WKWebView* web_view = [[[WKWebView alloc] init] autorelease]; 65 WKWebView* web_view = [[[WKWebView alloc] init] autorelease];
65 66
66 CRWJSWindowIDManager* manager = 67 CRWJSWindowIDManager* manager =
67 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view] autorelease]; 68 [[[CRWJSWindowIDManager alloc] initWithWebView:web_view] autorelease];
68 [manager inject]; 69 [manager inject];
69 EXPECT_TRUE([manager windowID]); 70 EXPECT_TRUE([manager windowID]);
70 EXPECT_FALSE(EvaluateJavaScript(web_view, @"window.__gCrWeb")); 71 EXPECT_FALSE(EvaluateJavaScript(web_view, @"window.__gCrWeb"));
71 72
72 // Now inject window.__gCrWeb and check if window ID injection retried. 73 // Now inject window.__gCrWeb and check if window ID injection retried.
73 EvaluateJavaScript(web_view, @"window.__gCrWeb = {};"); 74 EvaluateJavaScript(web_view, GetEarlyPageScript());
74 EXPECT_NSEQ([manager windowID], 75 EXPECT_NSEQ([manager windowID],
75 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId")); 76 EvaluateJavaScript(web_view, @"window.__gCrWeb.windowId"));
76 } 77 }
77 78
78 } // namespace web 79 } // namespace web
OLDNEW
« no previous file with comments | « no previous file | ios/web/web_state/js/resources/window_id.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698