Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/web/web_state/js/resources/window_id.js

Issue 2192503002: [ios] Cleaned up UIWebView workarounds from window_id.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/CRWJSWindowIdManager/CRWJSWindowIDManager Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/js/crw_js_window_id_manager_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/js/resources/window_id.js
diff --git a/ios/web/web_state/js/resources/window_id.js b/ios/web/web_state/js/resources/window_id.js
index 8935d8024bb28d5cb03cab1018ae0b727b0193e2..a9e9b9ee2d17c87116f8c20d0fcb69ece1ffe211 100644
--- a/ios/web/web_state/js/resources/window_id.js
+++ b/ios/web/web_state/js/resources/window_id.js
@@ -12,20 +12,10 @@
__gCrWeb['windowIdObject'] = {};
(function() {
- // CRWJSWindowIdManager replaces $(WINDOW_ID) with appropriate string upon
+ // CRWJSWindowIDManager replaces $(WINDOW_ID) with appropriate string upon
// injection.
__gCrWeb['windowId'] = '$(WINDOW_ID)';
- // Wrap queues flushing in setTimeout to avoid reentrant calls.
- // In some circumstances setTimeout does not work on iOS8 if set from
- // injected script. There is an assumption that it's happen when the script
- // has been injected too early. Do not place anything important to delayed
- // function body, since there is no guarantee that it will ever be executed.
- // TODO(eugenebut): Find out why setTimeout does not work (crbug.com/402682).
- window.setTimeout(function() {
- // Send messages queued since message.js injection.
- if (__gCrWeb.message) {
- __gCrWeb.message.invokeQueues();
- }
- }, 0);
+ // Send messages queued since message.js injection.
+ __gCrWeb.message.invokeQueues();
}());
« no previous file with comments | « ios/web/web_state/js/crw_js_window_id_manager_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698