Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2192493002: Let blink scheduler know when background parsing a document (Closed)

Created:
4 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 4 months ago
Reviewers:
Mike West, Sami
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let blink scheduler know when background parsing a document This is necessary to make Virtual time behave deterministically. Without knowing that a document is being parsed in the background we might think loading is safe to run timers (which it isn't if you want determinism). BUG=546953 Committed: https://crrev.com/1d65ae16d48a6639cae89b64f032b47e31c82c7e Cr-Commit-Position: refs/heads/master@{#408668}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename PAUSE_IF_NETWORK_FETCHES_PENDING to DETERMINISTIC_LOADING #

Patch Set 3 : Missed a couple of things to rename #

Patch Set 4 : Fix some test failures #

Messages

Total messages: 20 (11 generated)
alex clarke (OOO till 29th)
4 years, 4 months ago (2016-07-27 15:25:36 UTC) #2
Sami
lgtm.
4 years, 4 months ago (2016-07-27 16:45:10 UTC) #3
Mike West
//third_party/WebKit LGTM % two naming nits. https://codereview.chromium.org/2192493002/diff/1/third_party/WebKit/public/platform/WebFrameScheduler.h File third_party/WebKit/public/platform/WebFrameScheduler.h (right): https://codereview.chromium.org/2192493002/diff/1/third_party/WebKit/public/platform/WebFrameScheduler.h#newcode59 third_party/WebKit/public/platform/WebFrameScheduler.h:59: virtual void setDocumentParsedInBackground(bool) ...
4 years, 4 months ago (2016-07-29 13:49:09 UTC) #4
alex clarke (OOO till 29th)
https://codereview.chromium.org/2192493002/diff/1/third_party/WebKit/public/platform/WebFrameScheduler.h File third_party/WebKit/public/platform/WebFrameScheduler.h (right): https://codereview.chromium.org/2192493002/diff/1/third_party/WebKit/public/platform/WebFrameScheduler.h#newcode59 third_party/WebKit/public/platform/WebFrameScheduler.h:59: virtual void setDocumentParsedInBackground(bool) { } On 2016/07/29 13:49:08, Mike ...
4 years, 4 months ago (2016-07-29 14:07:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192493002/40001
4 years, 4 months ago (2016-07-29 15:04:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/209699)
4 years, 4 months ago (2016-07-29 15:47:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192493002/60001
4 years, 4 months ago (2016-07-29 15:55:32 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-29 17:11:05 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:12:24 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1d65ae16d48a6639cae89b64f032b47e31c82c7e
Cr-Commit-Position: refs/heads/master@{#408668}

Powered by Google App Engine
This is Rietveld 408576698