Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2192493002: Let blink scheduler know when background parsing a document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some test failures Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
index 49bed4d1dd5cac814544cb7738b094ed6336ad51..1c78fdab30549df0d4c18ca47d340da23aa115c3 100644
--- a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
@@ -502,10 +502,9 @@ TEST_F(WebViewSchedulerImplTest, DeleteThrottledQueue_InTask) {
EXPECT_EQ(10, run_count);
}
-TEST_F(WebViewSchedulerImplTest,
- VirtualTimePolicy_PAUSE_IF_NETWORK_FETCHES_PENDING) {
+TEST_F(WebViewSchedulerImplTest, VirtualTimePolicy_DETERMINISTIC_LOADING) {
web_view_scheduler_->setVirtualTimePolicy(
- VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);
+ VirtualTimePolicy::DETERMINISTIC_LOADING);
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
web_view_scheduler_->DidStartLoading(1u);
@@ -529,7 +528,7 @@ TEST_F(WebViewSchedulerImplTest,
TEST_F(WebViewSchedulerImplTest, RedundantDidStopLoadingCallsAreHarmless) {
web_view_scheduler_->setVirtualTimePolicy(
- VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);
+ VirtualTimePolicy::DETERMINISTIC_LOADING);
web_view_scheduler_->DidStartLoading(1u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
@@ -550,4 +549,22 @@ TEST_F(WebViewSchedulerImplTest, RedundantDidStopLoadingCallsAreHarmless) {
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
}
+TEST_F(WebViewSchedulerImplTest, BackgroundParser_DETERMINISTIC_LOADING) {
+ web_view_scheduler_->setVirtualTimePolicy(
+ VirtualTimePolicy::DETERMINISTIC_LOADING);
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->IncrementBackgroundParserCount();
+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->IncrementBackgroundParserCount();
+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DecrementBackgroundParserCount();
+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DecrementBackgroundParserCount();
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+}
+
} // namespace scheduler

Powered by Google App Engine
This is Rietveld 408576698