Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl.cc

Issue 2192493002: Let blink scheduler know when background parsing a document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some test failures Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_view_scheduler_impl.cc
diff --git a/components/scheduler/renderer/web_view_scheduler_impl.cc b/components/scheduler/renderer/web_view_scheduler_impl.cc
index da4e80b30b6fdcd2655f330e39d74d0bfb386137..0a9122f5502064f94b66d6ac0463b176c9590c15 100644
--- a/components/scheduler/renderer/web_view_scheduler_impl.cc
+++ b/components/scheduler/renderer/web_view_scheduler_impl.cc
@@ -25,6 +25,7 @@ WebViewSchedulerImpl::WebViewSchedulerImpl(
web_view_(web_view),
renderer_scheduler_(renderer_scheduler),
virtual_time_policy_(VirtualTimePolicy::ADVANCE),
+ background_parser_count_(0),
page_visible_(true),
disable_background_timer_throttling_(disable_background_timer_throttling),
allow_virtual_time_to_advance_(true) {
@@ -119,26 +120,23 @@ bool WebViewSchedulerImpl::virtualTimeAllowedToAdvance() const {
void WebViewSchedulerImpl::DidStartLoading(unsigned long identifier) {
pending_loads_.insert(identifier);
-
- if (virtual_time_policy_ !=
- VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING) {
- return;
- }
-
- if (pending_loads_.size() == 1u)
- setAllowVirtualTimeToAdvance(false);
+ ApplyVirtualTimePolicy();
}
void WebViewSchedulerImpl::DidStopLoading(unsigned long identifier) {
pending_loads_.erase(identifier);
+ ApplyVirtualTimePolicy();
+}
- if (virtual_time_policy_ !=
- VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING) {
- return;
- }
+void WebViewSchedulerImpl::IncrementBackgroundParserCount() {
+ background_parser_count_++;
+ ApplyVirtualTimePolicy();
+}
- if (pending_loads_.size() == 0)
- setAllowVirtualTimeToAdvance(true);
+void WebViewSchedulerImpl::DecrementBackgroundParserCount() {
+ background_parser_count_--;
+ DCHECK_GE(background_parser_count_, 0);
+ ApplyVirtualTimePolicy();
}
void WebViewSchedulerImpl::setVirtualTimePolicy(VirtualTimePolicy policy) {
@@ -153,10 +151,19 @@ void WebViewSchedulerImpl::setVirtualTimePolicy(VirtualTimePolicy policy) {
setAllowVirtualTimeToAdvance(false);
break;
- case VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING:
- setAllowVirtualTimeToAdvance(pending_loads_.size() == 0);
+ case VirtualTimePolicy::DETERMINISTIC_LOADING:
+ ApplyVirtualTimePolicy();
break;
}
}
+void WebViewSchedulerImpl::ApplyVirtualTimePolicy() {
+ if (virtual_time_policy_ != VirtualTimePolicy::DETERMINISTIC_LOADING) {
+ return;
+ }
+
+ setAllowVirtualTimeToAdvance(pending_loads_.size() == 0 &&
+ background_parser_count_ == 0);
+}
+
} // namespace scheduler

Powered by Google App Engine
This is Rietveld 408576698