third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 2192093004: [DevTools] Rename findObject to unwrapObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 2192093004: [DevTools] Rename findObject to unwrapObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index 8f0406ad5431ba90ee76538f63f6b8c48e7d4296..0bf4108e1eafebcf0906130a226ffc63d5ddfdfa 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -410,11 +410,10 @@ void InspectorDOMDebuggerAgent::removeDOMBreakpoint(ErrorString* errorString, in

void InspectorDOMDebuggerAgent::getEventListeners(ErrorString* errorString, const String& objectId, std::unique_ptr<protocol::Array<protocol::DOMDebugger::EventListener>>* listenersArray)

{

v8::HandleScope handles(m_isolate);

+ v8::Local<v8::Value> value;

v8::Local<v8::Context> context;

String16 objectGroup;

- v8::Local<v8::Value> value = m_v8Session->findObject(errorString, objectId, &context, &objectGroup);

- if (value.IsEmpty())

+ if (!m_v8Session->unwrapObject(errorString, objectId, &value, &context, &objectGroup))

return;

v8::Context::Scope scope(context);

*listenersArray = protocol::Array<protocol::DOMDebugger::EventListener>::create();