third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp - Issue 2192093004: [DevTools] Rename findObject to unwrapObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

Issue 2192093004: [DevTools] Rename findObject to unwrapObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

index 240dc3d27492e91624fc13ae458fd62ca4e2fdab..5776303da55f185ebf3da3aec206f98a12d85ff3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

@@ -290,8 +290,10 @@ void V8HeapProfilerAgentImpl::addInspectedHeapObject(ErrorString* errorString, c

void V8HeapProfilerAgentImpl::getHeapObjectId(ErrorString* errorString, const String16& objectId, String16* heapSnapshotObjectId)

{

v8::HandleScope handles(m_isolate);

- v8::Local<v8::Value> value = m_session->findObject(errorString, objectId);

- if (value.IsEmpty() || value->IsUndefined())

+ v8::Local<v8::Value> value;

+ v8::Local<v8::Context> context;

+ String16 objectGroup;

+ if (!m_session->unwrapObject(errorString, objectId, &value, &context, &objectGroup) || value->IsUndefined())

return;

v8::SnapshotObjectId id = m_isolate->GetHeapProfiler()->GetObjectId(value);