Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2192093004: [DevTools] Rename findObject to unwrapObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
index a81d2cc29b075c0576a2fb02765e824443c67e5d..6983950ebe28d74b44ef7b54989cfcb63324a518 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
@@ -1164,11 +1164,11 @@ void InspectorDOMAgent::innerHighlightQuad(std::unique_ptr<FloatQuad> quad, cons
Node* InspectorDOMAgent::nodeForRemoteId(ErrorString* errorString, const String& objectId)
{
v8::HandleScope handles(m_isolate);
- v8::Local<v8::Value> value = m_v8Session->findObject(errorString, objectId);
- if (value.IsEmpty()) {
- *errorString = "Node for given objectId not found";
+ v8::Local<v8::Value> value;
+ v8::Local<v8::Context> context;
+ String16 objectGroup;
+ if (!m_v8Session->unwrapObject(errorString, objectId, &value, &context, &objectGroup))
return nullptr;
- }
if (!V8Node::hasInstance(value, m_isolate)) {
*errorString = "Object id doesn't reference a Node";
return nullptr;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698