Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2191723002: Fix race condition with HasMutatorThread that was being used without a lock. (Closed)

Created:
4 years, 4 months ago by siva
Modified:
4 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix race condition with HasMutatorThread that was being used without a lock. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/b78aeee6f20dcad020267443bae6b00017f1eae0

Patch Set 1 #

Patch Set 2 : Address self review comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -25 lines) Patch
M runtime/vm/compiler.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 3 chunks +4 lines, -13 lines 2 comments Download
M runtime/vm/isolate.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/thread_registry.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/virtual_memory_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/virtual_memory_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/virtual_memory_macos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/virtual_memory_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 4 months ago (2016-07-27 23:58:44 UTC) #2
Florian Schneider
Lgtm. https://codereview.chromium.org/2191723002/diff/20001/runtime/vm/isolate.h File runtime/vm/isolate.h (left): https://codereview.chromium.org/2191723002/diff/20001/runtime/vm/isolate.h#oldcode187 runtime/vm/isolate.h:187: return mutator_thread_; Can you remove mutator_thread_ in BaseIsolate? ...
4 years, 4 months ago (2016-07-28 18:13:36 UTC) #3
siva
https://codereview.chromium.org/2191723002/diff/20001/runtime/vm/isolate.h File runtime/vm/isolate.h (left): https://codereview.chromium.org/2191723002/diff/20001/runtime/vm/isolate.h#oldcode187 runtime/vm/isolate.h:187: return mutator_thread_; On 2016/07/28 18:13:36, Florian Schneider wrote: > ...
4 years, 4 months ago (2016-07-28 20:15:10 UTC) #4
siva
4 years, 4 months ago (2016-07-29 01:32:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b78aeee6f20dcad020267443bae6b00017f1eae0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698