runtime/vm/virtual_memory_win.cc - Issue 2191723002: Fix race condition with HasMutatorThread that was being used without a lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_win.cc

Issue 2191723002: Fix race condition with HasMutatorThread that was being used without a lock. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address self review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/virtual_memory_win.cc

diff --git a/runtime/vm/virtual_memory_win.cc b/runtime/vm/virtual_memory_win.cc

index 8ea8fa52cb12255e9a7749a9fe63e1c590aa427d..25846136a996007789204103b8fc3aba808b33ed 100644

--- a/runtime/vm/virtual_memory_win.cc

+++ b/runtime/vm/virtual_memory_win.cc

@@ -66,7 +66,6 @@ bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {

bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {

ASSERT(Thread::Current()->IsMutatorThread() ||

- !Isolate::Current()->HasMutatorThread() ||

Isolate::Current()->mutator_thread()->IsAtSafepoint());

uword start_address = reinterpret_cast<uword>(address);

uword end_address = start_address + size;

« runtime/vm/isolate.h ('K') | « runtime/vm/virtual_memory_macos.cc ('k') | no next file » | no next file with comments »