runtime/vm/thread_registry.h - Issue 2191723002: Fix race condition with HasMutatorThread that was being used without a lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_registry.h

Issue 2191723002: Fix race condition with HasMutatorThread that was being used without a lock. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address self review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/thread_registry.h

diff --git a/runtime/vm/thread_registry.h b/runtime/vm/thread_registry.h

index adf2a346b66c89245a67266e42b370237f4be4d9..dd2c6df79fd606eebfa43f2706bcbdcc6423387a 100644

--- a/runtime/vm/thread_registry.h

+++ b/runtime/vm/thread_registry.h

@@ -26,6 +26,7 @@ class ThreadRegistry {

void VisitObjectPointers(ObjectPointerVisitor* visitor, bool validate_frames);

void PrepareForGC();

+ Thread* mutator_thread() const { return mutator_thread_; }

private:

Thread* active_list() const { return active_list_; }

« runtime/vm/isolate.h ('K') | « runtime/vm/isolate.cc ('k') | runtime/vm/virtual_memory_android.cc » ('j') | no next file with comments »