Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1986)

Issue 2191713004: Handle failed stack trace captures (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handle failed stack trace captures BUG=630953 R=yangguo@chromium.org Committed: https://crrev.com/da698896094f0b55bb7a168e4c9f5ebefa6174fd Cr-Commit-Position: refs/heads/master@{#38131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/builtins/builtins-error.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jgruber
4 years, 4 months ago (2016-07-28 08:34:21 UTC) #3
Yang
On 2016/07/28 08:34:21, jgruber wrote: lgtm.
4 years, 4 months ago (2016-07-28 11:04:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191713004/1
4 years, 4 months ago (2016-07-28 11:07:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 11:09:49 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 11:13:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da698896094f0b55bb7a168e4c9f5ebefa6174fd
Cr-Commit-Position: refs/heads/master@{#38131}

Powered by Google App Engine
This is Rietveld 408576698