Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: test/mjsunit/stack-traces.js

Issue 2191713004: Handle failed stack trace captures (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/stack-traces.js
diff --git a/test/mjsunit/stack-traces.js b/test/mjsunit/stack-traces.js
index a30a51548dfc40dbf8207501904f1eb6ef2daef5..6b8bdef97a3861f36698504fd3466111a035a771 100644
--- a/test/mjsunit/stack-traces.js
+++ b/test/mjsunit/stack-traces.js
@@ -386,3 +386,8 @@ Error.prepareStackTrace = function(e, frames) { throw 42; }
var x = {}
assertThrows(() => Error.captureStackTrace(x));
+
+// Check that we don't crash when CaptureSimpleStackTrace returns undefined.
+var o = {};
+Error.stackTraceLimit = "not a number";
+Error.captureStackTrace(o);
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698