src/builtins/builtins-error.cc - Issue 2191713004: Handle failed stack trace captures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-error.cc

Issue 2191713004: Handle failed stack trace captures (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-error.cc

diff --git a/src/builtins/builtins-error.cc b/src/builtins/builtins-error.cc

index 25cd9a29e46326bd536f223520ff29f2a67c87c0..118fc39d54a7a45d8c9a61e13ff31ee8b969732d 100644

--- a/src/builtins/builtins-error.cc

+++ b/src/builtins/builtins-error.cc

@@ -44,6 +44,7 @@ BUILTIN(ErrorCaptureStackTrace) {

Handle<Object> stack_trace =

isolate->CaptureSimpleStackTrace(object, mode, caller);

+ if (!stack_trace->IsJSArray()) return *isolate->factory()->undefined_value();

Handle<Object> formatted_stack_trace;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

« no previous file with comments | « no previous file | test/mjsunit/stack-traces.js » ('j') | no next file with comments »