Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2191663002: Fix silently-failing compile (Closed)

Created:
4 years, 4 months ago by borenet2
Modified:
4 years, 4 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix silently-failing compile Ouch... TBR=rmistry BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002 Committed: https://skia.googlesource.com/skia/+/151aee4220ae44d5458a41cc2109693a8d285783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -90 lines) Patch
M infra/bots/recipe_modules/skia/default_flavor.py View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/skia/fake_specs.py View 2 chunks +27 lines, -33 lines 0 comments Download
M infra/bots/recipes/swarm_compile.py View 2 chunks +17 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86-Debug.json View 4 chunks +10 lines, -11 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/failed_compile.json View 3 chunks +13 lines, -46 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
borenet
4 years, 4 months ago (2016-07-27 20:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191663002/1
4 years, 4 months ago (2016-07-27 20:15:17 UTC) #6
mtklein
lgtm oh... we smart.
4 years, 4 months ago (2016-07-27 20:15:39 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 21:05:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/151aee4220ae44d5458a41cc2109693a8d285783

Powered by Google App Engine
This is Rietveld 408576698