Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: infra/bots/recipes/swarm_compile.py

Issue 2191663002: Fix silently-failing compile (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipes/swarm_compile.py
diff --git a/infra/bots/recipes/swarm_compile.py b/infra/bots/recipes/swarm_compile.py
index 8e7370fdbc8698360aeeec90c93738ac66e68e18..274ca5af9520b3c226d03718e8d8cef82e63b144 100644
--- a/infra/bots/recipes/swarm_compile.py
+++ b/infra/bots/recipes/swarm_compile.py
@@ -25,6 +25,7 @@ TEST_BUILDERS = {
'Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot',
'Build-Ubuntu-GCC-Arm7-Release-Android',
'Build-Ubuntu-GCC-Arm7-Release-Android_Vulkan',
+ 'Build-Ubuntu-GCC-x86-Debug',
'Build-Ubuntu-GCC-x86_64-Debug-MSAN',
'Build-Ubuntu-GCC-x86_64-Release-CMake',
'Build-Ubuntu-GCC-x86_64-Release-PDFium',
@@ -83,6 +84,22 @@ def GenTests(api):
mastername = 'client.skia.compile'
slavename = 'skiabot-win-compile-000'
+ buildername = 'Build-Ubuntu-GCC-x86-Debug'
+ yield (
+ api.test('failed_compile') +
+ api.properties(buildername=buildername,
+ mastername=mastername,
+ slavename=slavename,
+ buildnumber=5,
+ revision='abc123',
+ path_config='kitchen',
+ swarm_out_dir='[SWARM_OUT_DIR]') +
+ api.path.exists(
+ api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
+ ) +
+ api.step_data('build most', retcode=1)
+ )
+
buildername = 'Build-Win-MSVC-x86-Debug'
yield (
api.test('win_retry_failed_compile') +

Powered by Google App Engine
This is Rietveld 408576698