infra/bots/recipe_modules/skia/default_flavor.py - Issue 2191663002: Fix silently-failing compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/skia/default_flavor.py

Issue 2191663002: Fix silently-failing compile (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipe_modules/skia/default_flavor.py

diff --git a/infra/bots/recipe_modules/skia/default_flavor.py b/infra/bots/recipe_modules/skia/default_flavor.py

index 3a444e44ba54b7aa6eff5d7cd3129fd1d3fa6c74..9c0734047ee1665338e1157e802955cc3514568d 100644

--- a/infra/bots/recipe_modules/skia/default_flavor.py

+++ b/infra/bots/recipe_modules/skia/default_flavor.py

@@ -144,6 +144,8 @@ class DefaultFlavorUtils(object):

# The linker occasionally crashes on Windows. Try again.

self._skia_api.run(self._skia_api.m.step, 'build %s' % target, cmd=cmd,

env=env, cwd=self._skia_api.m.path['checkout'])

+ else:

+ raise

if 'CommandBuffer' in self._skia_api.builder_name:

self._skia_api._run_once(self.build_command_buffer)

« no previous file with comments | « no previous file | infra/bots/recipe_modules/skia/fake_specs.py » ('j') | no next file with comments »