Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatPoint.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/FloatPoint.cpp b/third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
index c7b8cd475682decdbaa467a3e8174e1ac1bfa96f..440a4a3da7c69fbb04786abff6f198f8289e722b 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
+++ b/third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
@@ -31,9 +31,9 @@
#include "platform/geometry/DoublePoint.h"
#include "platform/geometry/LayoutPoint.h"
#include "platform/geometry/LayoutSize.h"
-#include "wtf/text/WTFString.h"
#include <limits>
#include <math.h>
+#include <ostream> // NOLINT
namespace blink {
@@ -114,11 +114,12 @@ bool findIntersection(const FloatPoint& p1, const FloatPoint& p2, const FloatPoi
return true;
}
-#ifndef NDEBUG
-String FloatPoint::toString() const
+std::ostream& operator<<(std::ostream& os, const FloatPoint& point)
{
- return String::format("%f,%f", x(), y());
+ os << "FloatPoint("
+ << "x=" << point.x() << ", "
+ << "y=" << point.y() << ")";
+ return os;
}
-#endif
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698