third_party/WebKit/Source/platform/geometry/FloatPoint.h - Issue 2191233002: Add platform/geometry pretty printers for logging and testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatPoint.h

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/geometry/FloatBox.cpp ('k') | third_party/WebKit/Source/platform/geometry/FloatPoint.cpp » ('j') | third_party/WebKit/Source/platform/geometry/IntRectTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/FloatPoint.h

diff --git a/third_party/WebKit/Source/platform/geometry/FloatPoint.h b/third_party/WebKit/Source/platform/geometry/FloatPoint.h

index a6f016682280db92c09642d5a6c2b63780e8e3df..77130fffdb15e8276e6fd20970735eb6fb0b3f45 100644

--- a/third_party/WebKit/Source/platform/geometry/FloatPoint.h

+++ b/third_party/WebKit/Source/platform/geometry/FloatPoint.h

@@ -158,10 +158,6 @@ public:

operator SkPoint() const { return SkPoint::Make(m_x, m_y); }

-#ifndef NDEBUG

- String toString() const;

-#endif

private:

float m_x, m_y;

};

@@ -279,9 +275,7 @@ inline FloatSize toFloatSize(const FloatPoint& a)

// Find point where lines through the two pairs of points intersect. Returns false if the lines don't intersect.

PLATFORM_EXPORT bool findIntersection(const FloatPoint& p1, const FloatPoint& p2, const FloatPoint& d1, const FloatPoint& d2, FloatPoint& intersection);

-// Redeclared here to avoid ODR issues.

-// See platform/testing/GeometryPrinters.h.

-void PrintTo(const FloatPoint&, std::ostream*);

+PLATFORM_EXPORT std::ostream& operator<<(std::ostream&, const FloatPoint&);

} // namespace blink