third_party/WebKit/Source/devtools/front_end/elements/module.json - Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/module.json

Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address CL feedback from PS6 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/module.json

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/module.json b/third_party/WebKit/Source/devtools/front_end/elements/module.json

index 4dbbc3d3b007ae867e05d034fe986388a0293b8c..df13560c4c8b2c08841f8395bb2bf1e9d2063a0f 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/module.json

+++ b/third_party/WebKit/Source/devtools/front_end/elements/module.json

@@ -196,7 +196,7 @@

"title": "DOM Breakpoints",

"order": 6,

"persistence": "permanent",

- "factoryName": "WebInspector.DOMBreakpointsSidebarPane.Proxy"

+ "factoryName": "WebInspector.DOMBreakpointsSidebarPane"

chenwilliam 2016/08/17 01:20:11 I initially tried className for both elements and

{

"type": "view",