third_party/WebKit/Source/devtools/front_end/elements/module.json - Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/module.json

Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address CL feedback from PS6 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "extensions": [	2 "extensions": [

3 {	3 {

4 "type": "@WebInspector.Panel",	4 "type": "@WebInspector.Panel",

5 "name": "elements",	5 "name": "elements",

6 "title": "Elements",	6 "title": "Elements",

7 "order": 10,	7 "order": 10,

8 "className": "WebInspector.ElementsPanel"	8 "className": "WebInspector.ElementsPanel"

9 },	9 },

10 {	10 {

(...skipping 178 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
189 "persistence": "permanent",	189 "persistence": "permanent",

190 "className": "WebInspector.EventListenersWidget"	190 "className": "WebInspector.EventListenersWidget"

191 },	191 },

192 {	192 {

193 "type": "view",	193 "type": "view",

194 "location": "elements-sidebar",	194 "location": "elements-sidebar",

195 "id": "elements.domBreakpoints",	195 "id": "elements.domBreakpoints",

196 "title": "DOM Breakpoints",	196 "title": "DOM Breakpoints",

197 "order": 6,	197 "order": 6,

198 "persistence": "permanent",	198 "persistence": "permanent",

199 "factoryName": "WebInspector.DOMBreakpointsSidebarPane.Proxy"	199 "factoryName": "WebInspector.DOMBreakpointsSidebarPane"
	chenwilliam 2016/08/17 01:20:11 I initially tried className for both elements and I initially tried className for both elements and sources module.json but I couldn't debug why one panel would corrupt the UI on the other panel. It's a bit more inefficient to use factoryName but it works properly.
200 },	200 },

201 {	201 {

202 "type": "view",	202 "type": "view",

203 "location": "elements-sidebar",	203 "location": "elements-sidebar",

204 "id": "elements.domProperties",	204 "id": "elements.domProperties",

205 "title": "Properties",	205 "title": "Properties",

206 "order": 7,	206 "order": 7,

207 "persistence": "permanent",	207 "persistence": "permanent",

208 "className": "WebInspector.PropertiesWidget"	208 "className": "WebInspector.PropertiesWidget"

209 }	209 }

(...skipping 26 matching lines...) Expand all Loading...
236 ],	236 ],

237 "resources": [	237 "resources": [

238 "bezierEditor.css",	238 "bezierEditor.css",

239 "breadcrumbs.css",	239 "breadcrumbs.css",

240 "computedStyleSidebarPane.css",	240 "computedStyleSidebarPane.css",

241 "elementsPanel.css",	241 "elementsPanel.css",

242 "elementsTreeOutline.css",	242 "elementsTreeOutline.css",

243 "platformFontsWidget.css"	243 "platformFontsWidget.css"

244 ]	244 ]

245 }	245 }

OLD	NEW