Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address CL feedback from PS6 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index a22d5a3b9c9140399ddd7768bb6c59c8025bc186..e2fdf845121ea6b3de91554c27236e0576d1405b 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -386,8 +386,6 @@ WebInspector.ElementsPanel.prototype = {
return;
}
- WebInspector.domBreakpointsSidebarPane.restoreBreakpoints(domModel);
-
/**
* @this {WebInspector.ElementsPanel}
* @param {?WebInspector.DOMNode} candidateFocusNode
@@ -969,10 +967,36 @@ WebInspector.ElementsPanel.ContextMenuProvider.prototype = {
return;
}
- // Add debbuging-related actions
+ /**
+ * @param {!WebInspector.DOMNode} node
+ * @param {!WebInspector.ContextMenu} contextMenu
+ */
+ function populateNodeContextMenu(node, contextMenu)
+ {
+ if (node.pseudoType())
+ return;
+
+ var nodeBreakpoints = WebInspector.domBreakpointManager.nodeBreakpoints(node);
+
+ /**
+ * @param {!DOMDebuggerAgent.DOMBreakpointType} type
+ */
+ function toggleBreakpoint(type)
+ {
+ WebInspector.domBreakpointManager.toggleBreakpoint(node, type);
+ }
+ var breakpointsMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Break on..."));
+ for (var key in WebInspector.DOMBreakpointsSidebarPane.BreakpointTypes) {
+ var type = WebInspector.DOMBreakpointsSidebarPane.BreakpointTypes[key];
+ var label = WebInspector.DOMBreakpointsSidebarPane.ContextMenuLabels[type];
+ breakpointsMenu.appendCheckboxItem(label, toggleBreakpoint.bind(null, type), nodeBreakpoints.get(type));
+ }
+ }
+
+ // Add debugging-related actions
if (object instanceof WebInspector.DOMNode) {
contextMenu.appendSeparator();
- WebInspector.domBreakpointsSidebarPane.populateNodeContextMenu(object, contextMenu, true);
+ populateNodeContextMenu(object, contextMenu);
}
// Skip adding "Reveal..." menu item for our own tree outline.

Powered by Google App Engine
This is Rietveld 408576698