Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2190693002: [merge to M53] Make sure Widget::dispose() respects UpdateSuspendScope. (Closed)

Created:
4 years, 4 months ago by awhalley
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[merge to M53] Make sure Widget::dispose() respects UpdateSuspendScope. BUG=621362 Review-Url: https://codereview.chromium.org/2171683002 Cr-Commit-Position: refs/heads/master@{#406802} (cherry picked from commit cade7295256e7adabf84272fe5e269834eb44dde) TBR=dcheng NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 3 chunks +31 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190693002/1
4 years, 4 months ago (2016-07-27 17:41:33 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-07-27 17:41:39 UTC) #5
Charlie Reis
LGTM!
4 years, 4 months ago (2016-07-27 17:46:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190693002/1
4 years, 4 months ago (2016-07-27 17:47:31 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:50:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698