third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2190693002: [merge to M53] Make sure Widget::dispose() respects UpdateSuspendScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2190693002: [merge to M53] Make sure Widget::dispose() respects UpdateSuspendScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index 90f9055ea29dde58a7f03e738f2173407097f168..c55ea5b70ed55e109d9254226548028485a70796 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -89,7 +89,7 @@ void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget)

if (m_persistedPluginWidget) {

if (m_persistedPluginWidget->isPluginView()) {

m_persistedPluginWidget->hide();

- m_persistedPluginWidget->dispose();

+ disposeWidgetSoon(m_persistedPluginWidget.release());

} else {

ASSERT(m_persistedPluginWidget->isFrameView() || m_persistedPluginWidget->isRemoteFrameView());

}

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp ('k') | no next file » | no next file with comments »