Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2190513002: Add crash keys for ServiceWorkerDispatcherHost crashes (Closed)

Created:
4 years, 4 months ago by horo
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tzik, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kinuko+watch, shaktisahu+watch-blimp_chromium.org, jsbell+serviceworker_chromium.org, maniscalco+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, blink-worker-reviews_chromium.org, nhiroki, khushalsagar+watch-blimp_chromium.org, michaeln, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, serviceworker-reviews, kinuko+serviceworker, horo+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add crash keys for ServiceWorkerDispatcherHost crashes BUG=619294, 630495, 630496 Committed: https://crrev.com/587e8127d8c3fda4d66fea1da6fec3ff9890588e Cr-Commit-Position: refs/heads/master@{#408561}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
horo
nhiroki@ Could you please review this?
4 years, 4 months ago (2016-07-27 06:57:01 UTC) #5
nhiroki
lgtm with a nit https://codereview.chromium.org/2190513002/diff/20001/chrome/app/chrome_crash_reporter_client_win.cc File chrome/app/chrome_crash_reporter_client_win.cc (right): https://codereview.chromium.org/2190513002/diff/20001/chrome/app/chrome_crash_reporter_client_win.cc#newcode164 chrome/app/chrome_crash_reporter_client_win.cc:164: { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize }, Looks ...
4 years, 4 months ago (2016-07-27 07:24:52 UTC) #6
horo
https://codereview.chromium.org/2190513002/diff/20001/chrome/app/chrome_crash_reporter_client_win.cc File chrome/app/chrome_crash_reporter_client_win.cc (right): https://codereview.chromium.org/2190513002/diff/20001/chrome/app/chrome_crash_reporter_client_win.cc#newcode164 chrome/app/chrome_crash_reporter_client_win.cc:164: { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize }, On 2016/07/27 07:24:51, nhiroki wrote: ...
4 years, 4 months ago (2016-07-27 07:32:16 UTC) #8
horo
sky@ Please review this.
4 years, 4 months ago (2016-07-27 07:32:38 UTC) #9
horo
wez@ Please review blimp/engine/app/blimp_engine_crash_keys.cc.
4 years, 4 months ago (2016-07-27 14:58:06 UTC) #11
sky
+ananta, who should be an owner of these files.
4 years, 4 months ago (2016-07-27 15:37:37 UTC) #13
ananta
chrome_crash_reporter_client_win.cc LGTM
4 years, 4 months ago (2016-07-27 21:02:41 UTC) #14
sky
Rubber stamp LGTM
4 years, 4 months ago (2016-07-27 21:57:32 UTC) #15
horo
rsesek@ Could you please review blimp/engine/app/blimp_engine_crash_keys.cc?
4 years, 4 months ago (2016-07-29 00:02:29 UTC) #17
Wez
blimp/ LGTM
4 years, 4 months ago (2016-07-29 00:20:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190513002/40001
4 years, 4 months ago (2016-07-29 01:41:56 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-07-29 02:50:05 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 02:51:40 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/587e8127d8c3fda4d66fea1da6fec3ff9890588e
Cr-Commit-Position: refs/heads/master@{#408561}

Powered by Google App Engine
This is Rietveld 408576698