Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2190513002: Add crash keys for ServiceWorkerDispatcherHost crashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 {"aci_wrong_sp_extension_id", kSmallSize}, 142 {"aci_wrong_sp_extension_id", kSmallSize},
143 143
144 // Temporary for http://crbug.com/621730 144 // Temporary for http://crbug.com/621730
145 {"postmessage_src_origin", kMediumSize}, 145 {"postmessage_src_origin", kMediumSize},
146 {"postmessage_dst_origin", kMediumSize}, 146 {"postmessage_dst_origin", kMediumSize},
147 {"postmessage_dst_url", kLargeSize}, 147 {"postmessage_dst_url", kLargeSize},
148 {"postmessage_script_info", kLargeSize}, 148 {"postmessage_script_info", kLargeSize},
149 149
150 // Temporary for https://crbug.com/616149. 150 // Temporary for https://crbug.com/616149.
151 {"existing_extension_pref_value_type", crash_keys::kSmallSize}, 151 {"existing_extension_pref_value_type", crash_keys::kSmallSize},
152
153 // Temporary for https://crbug.com/630495.
154 { "swdh_register_cannot_host_url", crash_keys::kLargeSize },
155 { "swdh_register_cannot_scope_url", crash_keys::kLargeSize },
156 { "swdh_register_cannot_script_url", crash_keys::kLargeSize },
157
158 // Temporary for https://crbug.com/619294.
159 { "swdh_unregister_cannot_host_url", crash_keys::kLargeSize },
160 { "swdh_unregister_cannot_scope_url", crash_keys::kLargeSize },
161
162 // Temporary for https://crbug.com/630496.
163 { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize },
164 { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize },
nhiroki 2016/07/27 07:24:51 Looks strange, but there are no spaces after '{' a
horo 2016/07/27 07:32:15 Done.
152 }; 165 };
153 166
154 // This dynamic set of keys is used for sets of key value pairs when gathering 167 // This dynamic set of keys is used for sets of key value pairs when gathering
155 // a collection of data, like command line switches or extension IDs. 168 // a collection of data, like command line switches or extension IDs.
156 std::vector<base::debug::CrashKey> keys(fixed_keys, 169 std::vector<base::debug::CrashKey> keys(fixed_keys,
157 fixed_keys + arraysize(fixed_keys)); 170 fixed_keys + arraysize(fixed_keys));
158 171
159 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 172 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
160 173
161 // Register the extension IDs. 174 // Register the extension IDs.
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 bool ChromeCrashReporterClient::GetCollectStatsConsent() { 355 bool ChromeCrashReporterClient::GetCollectStatsConsent() {
343 return install_static::GetCollectStatsConsent(); 356 return install_static::GetCollectStatsConsent();
344 } 357 }
345 358
346 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 359 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
347 const std::string& process_type) { 360 const std::string& process_type) {
348 return process_type == install_static::kRendererProcess || 361 return process_type == install_static::kRendererProcess ||
349 process_type == install_static::kPpapiPluginProcess || 362 process_type == install_static::kPpapiPluginProcess ||
350 process_type == install_static::kGpuProcess; 363 process_type == install_static::kGpuProcess;
351 } 364 }
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698