Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 2190513002: Add crash keys for ServiceWorkerDispatcherHost crashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove space Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index 577d660a482f4ab0b30040626fc28b98f9956fc6..7355acc9a7b1f8ebfca03c71eb8ab67235c443be 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/debug/crash_logging.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
@@ -320,6 +321,13 @@ void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
if (!ServiceWorkerUtils::CanRegisterServiceWorker(
provider_host->document_url(), pattern, script_url)) {
+ // Temporary debugging for https://crbug.com/630495
+ base::debug::ScopedCrashKey host_url_key(
+ "swdh_register_cannot_host_url", provider_host->document_url().spec());
+ base::debug::ScopedCrashKey scope_url_key("swdh_register_cannot_scope_url",
+ pattern.spec());
+ base::debug::ScopedCrashKey script_url_key(
+ "swdh_register_cannot_script_url", script_url.spec());
bad_message::ReceivedBadMessage(this, bad_message::SWDH_REGISTER_CANNOT);
return;
}
@@ -486,6 +494,12 @@ void ServiceWorkerDispatcherHost::OnUnregisterServiceWorker(
if (!CanUnregisterServiceWorker(provider_host->document_url(),
registration->pattern())) {
+ // Temporary debugging for https://crbug.com/619294
+ base::debug::ScopedCrashKey host_url_key(
+ "swdh_unregister_cannot_host_url",
+ provider_host->document_url().spec());
+ base::debug::ScopedCrashKey scope_url_key(
+ "swdh_unregister_cannot_scope_url", registration->pattern().spec());
bad_message::ReceivedBadMessage(this, bad_message::SWDH_UNREGISTER_CANNOT);
return;
}
@@ -555,6 +569,12 @@ void ServiceWorkerDispatcherHost::OnGetRegistration(
}
if (!CanGetRegistration(provider_host->document_url(), document_url)) {
+ // Temporary debugging for https://crbug.com/630496
+ base::debug::ScopedCrashKey host_url_key(
+ "swdh_get_registration_cannot_host_url",
+ provider_host->document_url().spec());
+ base::debug::ScopedCrashKey document_url_key(
+ "swdh_get_registration_cannot_document_url", document_url.spec());
bad_message::ReceivedBadMessage(this,
bad_message::SWDH_GET_REGISTRATION_CANNOT);
return;
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698