Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2190433002:
libmtp: fix build error with glibc 2.23 (Closed)
|
Created:
4 years, 4 months ago by yunlian Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/deps/libmtp@master Target Ref:
refs/heads/master Project:
chromium_deps Visibility:
Public. |
Descriptionlibmtp: fix build error with glibc 2.23
With glibc 2.23, libmtp fails to build.
This CL fixes that.
BUG=chromium:616824
TEST=libmtp builds with glibc 2.23
Patch Set 1 #
Messages
Total messages: 16 (2 generated)
yunlian@chromium.org changed reviewers: + thestig@chromium.org, yawano@chromium.org
I lost my local checkout for https://codereview.chromium.org/2091503002/ So I upload a new CL instead.
On 2016/07/26 22:38:24, yunlian wrote: > I lost my local checkout for > https://codereview.chromium.org/2091503002/ > So I upload a new CL instead. You can do "git cl issue NNN" to reassociate, but no worries, I closed the other CL since you created this one.
lgtm
On 2016/07/26 23:09:39, Lei Zhang wrote: > lgtm Do I need permission to land this CL? git cl land Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit commit checks ... Presubmit checks passed. Description: libmtp: fix build error with glibc 2.23 With glibc 2.23, libmtp fails to build. This CL fixes that. BUG=chromium:616824 TEST=libmtp builds with glibc 2.23 R=thestig@chromium.org Review URL: https://codereview.chromium.org/2190433002 . patches/21_fix_build_with_new_glibc.patch | 15 +++++++++++++++ src/util.h | 4 ++++ 2 files changed, 19 insertions(+) Counting objects: 6, done. Delta compression using up to 48 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 901 bytes | 0 bytes/s, done. Total 6 (delta 4), reused 0 (delta 0) remote: Resolving deltas: 100% (4/4) remote: Processing changes: refs: 1, done error: failed to push some refs to 'https://chromium.googlesource.com/chromium/deps/libmtp' Failed to push. If this persists, please file a bug.
On 2016/07/26 23:19:54, yunlian wrote: > On 2016/07/26 23:09:39, Lei Zhang wrote: > > lgtm > > Do I need permission to land this CL? I think yawano@ might know. I honestly don't remember.
On 2016/07/26 23:23:47, Lei Zhang wrote: > On 2016/07/26 23:19:54, yunlian wrote: > > On 2016/07/26 23:09:39, Lei Zhang wrote: > > > lgtm > > > > Do I need permission to land this CL? > > I think yawano@ might know. I honestly don't remember. lgtm. What permission do you mean? IIRC, you can land this cl as you land cl to chrome repository. But you will need to change base URL of this CL (or upload a new CL with new base URL). When I tried to land cl to the base URL, it was rejected. https://crrev.com/898023002 https://crrev.com/900383002 is a CL which has the right base url to land.
On 2016/07/27 00:27:08, yawano wrote: > On 2016/07/26 23:23:47, Lei Zhang wrote: > > On 2016/07/26 23:19:54, yunlian wrote: > > > On 2016/07/26 23:09:39, Lei Zhang wrote: > > > > lgtm > > > > > > Do I need permission to land this CL? > > > > I think yawano@ might know. I honestly don't remember. > > lgtm. > > What permission do you mean? > IIRC, you can land this cl as you land cl to chrome repository. > But you will need to change base URL of this CL (or upload a new CL with new > base URL). > When I tried to land cl to the base URL, it was rejected. > https://crrev.com/898023002 > > https://crrev.com/900383002 is a CL which has the right base url to land. How can I find the right base url? My cl is based on https://chromium.googlesource.com/chromium/deps/libmtp/ Thanks
On 2016/07/27 17:33:23, yunlian wrote: > On 2016/07/27 00:27:08, yawano wrote: > > On 2016/07/26 23:23:47, Lei Zhang wrote: > > > On 2016/07/26 23:19:54, yunlian wrote: > > > > On 2016/07/26 23:09:39, Lei Zhang wrote: > > > > > lgtm > > > > > > > > Do I need permission to land this CL? > > > > > > I think yawano@ might know. I honestly don't remember. > > > > lgtm. > > > > What permission do you mean? > > IIRC, you can land this cl as you land cl to chrome repository. > > But you will need to change base URL of this CL (or upload a new CL with new > > base URL). > > When I tried to land cl to the base URL, it was rejected. > > https://crrev.com/898023002 > > > > https://crrev.com/900383002 is a CL which has the right base url to land. > > How can I find the right base url? > My cl is based on > https://chromium.googlesource.com/chromium/deps/libmtp/ > > Thanks Sorry, I forgot that we might have migrated to git. At the last time when I submitted a CL, right base URL was one used in https://crrev.com/900383002, svn://svn.chromium.org/chrome/trunk/deps/third_party/libmtp/ Could you give a try with current base URL?
On 2016/07/28 06:53:25, yawano wrote: > On 2016/07/27 17:33:23, yunlian wrote: > > On 2016/07/27 00:27:08, yawano wrote: > > > On 2016/07/26 23:23:47, Lei Zhang wrote: > > > > On 2016/07/26 23:19:54, yunlian wrote: > > > > > On 2016/07/26 23:09:39, Lei Zhang wrote: > > > > > > lgtm > > > > > > > > > > Do I need permission to land this CL? > > > > > > > > I think yawano@ might know. I honestly don't remember. > > > > > > lgtm. > > > > > > What permission do you mean? > > > IIRC, you can land this cl as you land cl to chrome repository. > > > But you will need to change base URL of this CL (or upload a new CL with new > > > base URL). > > > When I tried to land cl to the base URL, it was rejected. > > > https://crrev.com/898023002 > > > > > > https://crrev.com/900383002 is a CL which has the right base url to land. > > > > How can I find the right base url? > > My cl is based on > > https://chromium.googlesource.com/chromium/deps/libmtp/ > > > > Thanks > > Sorry, I forgot that we might have migrated to git. > At the last time when I submitted a CL, right base URL was one used in > https://crrev.com/900383002, > svn://svn.chromium.org/chrome/trunk/deps/third_party/libmtp/ > > Could you give a try with current base URL? I think libmtp has migrated to git. Probably we should use git instead of svn?
On 2016/07/28 16:14:56, yunlian wrote: > On 2016/07/28 06:53:25, yawano wrote: > > On 2016/07/27 17:33:23, yunlian wrote: > > > On 2016/07/27 00:27:08, yawano wrote: > > > > On 2016/07/26 23:23:47, Lei Zhang wrote: > > > > > On 2016/07/26 23:19:54, yunlian wrote: > > > > > > On 2016/07/26 23:09:39, Lei Zhang wrote: > > > > > > > lgtm > > > > > > > > > > > > Do I need permission to land this CL? > > > > > > > > > > I think yawano@ might know. I honestly don't remember. > > > > > > > > lgtm. > > > > > > > > What permission do you mean? > > > > IIRC, you can land this cl as you land cl to chrome repository. > > > > But you will need to change base URL of this CL (or upload a new CL with > new > > > > base URL). > > > > When I tried to land cl to the base URL, it was rejected. > > > > https://crrev.com/898023002 > > > > > > > > https://crrev.com/900383002 is a CL which has the right base url to land. > > > > > > How can I find the right base url? > > > My cl is based on > > > https://chromium.googlesource.com/chromium/deps/libmtp/ > > > > > > Thanks > > > > Sorry, I forgot that we might have migrated to git. > > At the last time when I submitted a CL, right base URL was one used in > > https://crrev.com/900383002, > > svn://svn.chromium.org/chrome/trunk/deps/third_party/libmtp/ > > > > Could you give a try with current base URL? > > I think libmtp has migrated to git. Probably we should use git instead of svn? What happens if you try to land this CL with git cl land? Yes, we should use git but I don't know the right base URL for it.
On 2016/07/29 00:31:14, yawano wrote: > On 2016/07/28 16:14:56, yunlian wrote: > > On 2016/07/28 06:53:25, yawano wrote: > > > On 2016/07/27 17:33:23, yunlian wrote: > > > > On 2016/07/27 00:27:08, yawano wrote: > > > > > On 2016/07/26 23:23:47, Lei Zhang wrote: > > > > > > On 2016/07/26 23:19:54, yunlian wrote: > > > > > > > On 2016/07/26 23:09:39, Lei Zhang wrote: > > > > > > > > lgtm > > > > > > > > > > > > > > Do I need permission to land this CL? > > > > > > > > > > > > I think yawano@ might know. I honestly don't remember. > > > > > > > > > > lgtm. > > > > > > > > > > What permission do you mean? > > > > > IIRC, you can land this cl as you land cl to chrome repository. > > > > > But you will need to change base URL of this CL (or upload a new CL with > > new > > > > > base URL). > > > > > When I tried to land cl to the base URL, it was rejected. > > > > > https://crrev.com/898023002 > > > > > > > > > > https://crrev.com/900383002 is a CL which has the right base url to > land. > > > > > > > > How can I find the right base url? > > > > My cl is based on > > > > https://chromium.googlesource.com/chromium/deps/libmtp/ > > > > > > > > Thanks > > > > > > Sorry, I forgot that we might have migrated to git. > > > At the last time when I submitted a CL, right base URL was one used in > > > https://crrev.com/900383002, > > > svn://svn.chromium.org/chrome/trunk/deps/third_party/libmtp/ > > > > > > Could you give a try with current base URL? > > > > I think libmtp has migrated to git. Probably we should use git instead of svn? > > What happens if you try to land this CL with git cl land? Yes, we should use git > but I don't know the right base URL for it. I got the error below. I suspect it is because I do not have permission to commit code to this repository, but I am not sure. git cl land Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit commit checks ... Presubmit checks passed. Description: libmtp: fix build error with glibc 2.23 With glibc 2.23, libmtp fails to build. This CL fixes that. BUG=chromium:616824 TEST=libmtp builds with glibc 2.23 R=thestig@chromium.org Review URL: https://codereview.chromium.org/2190433002 . patches/21_fix_build_with_new_glibc.patch | 15 +++++++++++++++ src/util.h | 4 ++++ 2 files changed, 19 insertions(+) Counting objects: 6, done. Delta compression using up to 48 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 901 bytes | 0 bytes/s, done. Total 6 (delta 4), reused 0 (delta 0) remote: Resolving deltas: 100% (4/4) remote: Processing changes: refs: 1, done error: failed to push some refs to 'https://chromium.googlesource.com/chromium/deps/libmtp' Failed to push. If this persists, please file a bug.
Let me try landing this for you and see if I have better luck. (or permissions)
On 2016/07/29 16:32:06, Lei Zhang wrote: > Let me try landing this for you and see if I have better luck. (or permissions) Thanks!
On 2016/07/29 18:30:40, yunlian wrote: > On 2016/07/29 16:32:06, Lei Zhang wrote: > > Let me try landing this for you and see if I have better luck. (or > permissions) > > Thanks! Landed in https://codereview.chromium.org/2195013002/
Description was changed from ========== libmtp: fix build error with glibc 2.23 With glibc 2.23, libmtp fails to build. This CL fixes that. BUG=chromium:616824 TEST=libmtp builds with glibc 2.23 ========== to ========== libmtp: fix build error with glibc 2.23 With glibc 2.23, libmtp fails to build. This CL fixes that. BUG=chromium:616824 TEST=libmtp builds with glibc 2.23 ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
