Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2091503002: libmtp: fix build error with glibc 2.23 (Closed)

Created:
4 years, 6 months ago by yunlian
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, yawano
CC:
chromium-reviews, cmtice
Base URL:
https://chromium.googlesource.com/chromium/deps/libmtp@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

libmtp: fix build error with glibc 2.23 With glibc 2.23, libmtp fails to build. This CL fixes that. BUG=chromium:616824 TEST=libmtp builds with glibc 2.23

Patch Set 1 #

Patch Set 2 : libmtp: fix build error with glibc 2.23 #

Patch Set 3 : libmtp: fix build error with glibc 2.23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A patches/21_fix_build_with_new_glibc.patch View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
yunlian
4 years, 6 months ago (2016-06-22 19:00:02 UTC) #2
Lei Zhang
LGTM! Hopefully this is the right repo + review tool.
4 years, 6 months ago (2016-06-22 23:58:09 UTC) #3
yunlian
On 2016/06/22 23:58:09, Lei Zhang (Slow) wrote: > LGTM! Hopefully this is the right repo ...
4 years, 6 months ago (2016-06-23 00:00:10 UTC) #4
yawano
not-lgtm for format. Please put your patch under patch folder. - https://chromium.googlesource.com/chromium/deps/libmtp/+/master/patches/
4 years, 6 months ago (2016-06-23 00:01:04 UTC) #5
yawano
Sorry, I should have typed not lgtm instead of not-lgtm.
4 years, 6 months ago (2016-06-23 00:03:21 UTC) #6
cmtice1
On 2016/06/23 00:03:21, yawano wrote: > Sorry, I should have typed not lgtm instead of ...
4 years, 5 months ago (2016-06-29 18:22:01 UTC) #7
yawano
No, but it's just a format issue. Please add a patch under patches as we ...
4 years, 5 months ago (2016-06-30 07:07:43 UTC) #9
cmtice1
4 years, 5 months ago (2016-06-30 18:52:20 UTC) #10
On 2016/06/30 07:07:43, yawano wrote:
> No, but it's just a format issue. Please add a patch under patches as we are
> doing for other CLs.
> https://chromium.googlesource.com/chromium/deps/libmtp/+/master/patches/
> 
> An example CL: https://crrev.com/900383002

Ok, we'll have Yunlian do that when he comes back.

Powered by Google App Engine
This is Rietveld 408576698