Enable stream trace retrieval when start-up tracing is used

Enable stream trace retrieval when start-up tracing is used

This will only have effect once https://codereview.chromium.org/2180423004
is landed and should be ignored by older browsers.

BUG=chromium:632155
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6b0563110dd86f37eaa557b527125431595a3653

[caseq, 2016-07-28 00:04:28]

caseq@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com

[nednguyen, 2016-07-28 00:43:48]

lgtm 

Feel free to land this as-is since all of this should go away when we make
streaming the default way (or the only way) :-)

https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
(right):

https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py:169: #
Tracing is running but start was not issued so background tracing must
nits: s/background tracing/startup tracing

https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py:173:
'transferMode': 'ReturnAsStream',
Can we not put this in the tracing config file used for startup tracing?

[caseq, 2016-07-28 00:59:40]

On 2016/07/28 00:43:48, nednguyen wrote:

> Feel free to land this as-is since all of this should go away when we make
> streaming the default way (or the only way) :-)

Well, it will take some time, since even DevTools front-end currently uses the
old mode.

>
https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
> File telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
> (right):
> 
>
https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
> telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py:169:
#
> Tracing is running but start was not issued so background tracing must
> nits: s/background tracing/startup tracing

fixed, thanks for catching!

> 
>
https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
> telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py:173:
> 'transferMode': 'ReturnAsStream',
> Can we not put this in the tracing config file used for startup tracing?

This is currently not part of the trace config, since we presume it to be on a
different level (i.e. transferMode is specific to the DevTools protocol, while
Tracing is on a lower level and may be retrieved by other means).

[nednguyen, 2016-07-28 01:00:49]

On 2016/07/28 00:59:40, caseq wrote:
> On 2016/07/28 00:43:48, nednguyen wrote:
> 
> > Feel free to land this as-is since all of this should go away when we make
> > streaming the default way (or the only way) :-)
> 
> Well, it will take some time, since even DevTools front-end currently uses the
> old mode.
> 
> >
>
https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
> > File
telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
> >
telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py:169:
> #
> > Tracing is running but start was not issued so background tracing must
> > nits: s/background tracing/startup tracing
> 
> fixed, thanks for catching!
> 
> > 
> >
>
https://codereview.chromium.org/2189823002/diff/1/telemetry/telemetry/interna...
> >
telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py:173:
> > 'transferMode': 'ReturnAsStream',
> > Can we not put this in the tracing config file used for startup tracing?
> 
> This is currently not part of the trace config, since we presume it to be on a
> different level (i.e. transferMode is specific to the DevTools protocol, while
> Tracing is on a lower level and may be retrieved by other means).

Ah, makes sense.

[caseq, 2016-07-28 16:11:04]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-07-28 16:11:05]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2189823002/#ps20001
(title: "fixed typo")

[commit-bot: I haz the power, 2016-07-28 16:11:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 16:35:57]

Description was changed from

==========
Enable stream trace retrieval when start-up tracing is used

This will only have effect once https://codereview.chromium.org/2180423004
is landed and should be ignored by older browsers.

BUG=chromium:632155
==========

to

==========
Enable stream trace retrieval when start-up tracing is used

This will only have effect once https://codereview.chromium.org/2180423004
is landed and should be ignored by older browsers.

BUG=chromium:632155

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-28 16:35:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...