DevTools: update transfer mode in Tracing.start when using start-up tracing

DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG=632155
This allows clients to issue Tracing.start when tracing is already running, but only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode, as Tracing.start is currently the only way to specify it.

Committed: https://crrev.com/e886e3aeb93dd1786d6c3323a2cbd2aa8d99b407
Cr-Commit-Position: refs/heads/master@{#408301}

[caseq, 2016-07-27 21:43:56]

caseq@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-07-27 21:46:47]

lgtm

[alph, 2016-07-27 21:47:11]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-07-27 21:47:11]

https://codereview.chromium.org/2180423004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/2180423004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/tracing_handler.cc:188: transfer_mode &&
*transfer_mode == start::kTransferModeReturnAsStream;
padding

[caseq, 2016-07-27 21:57:40]

Description was changed from

==========
DevTools: update transfer mode in Tracing.start when using start-up tracing

This allows clients to issue Tracing.start when tracing is already running,
but only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer
mode, as Tracing.start is currently the only way to specify it.
==========

to

==========
DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG=632155

This allows clients to issue Tracing.start when tracing is already running, but
only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode,
as Tracing.start is currently the only way to specify it.
==========

[caseq, 2016-07-27 21:57:49]

The CQ bit was checked by caseq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 21:58:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 22:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 22:03:20]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2016-07-28 00:04:52]

The CQ bit was checked by caseq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 00:05:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 00:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 00:39:04]

Dry run: This issue passed the CQ dry run.

[caseq, 2016-07-28 00:53:28]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-07-28 00:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2180423004/#ps20001
(title: "DevTools: update transfer mode in Tracing.start when using start-up
tracing")

[commit-bot: I haz the power, 2016-07-28 00:53:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 00:57:44]

Description was changed from

==========
DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG=632155

This allows clients to issue Tracing.start when tracing is already running, but
only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode,
as Tracing.start is currently the only way to specify it.
==========

to

==========
DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG=632155

This allows clients to issue Tracing.start when tracing is already running, but
only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode,
as Tracing.start is currently the only way to specify it.
==========

[commit-bot: I haz the power, 2016-07-28 00:57:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 01:00:30]

Description was changed from

==========
DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG=632155

This allows clients to issue Tracing.start when tracing is already running, but
only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode,
as Tracing.start is currently the only way to specify it.
==========

to

==========
DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG=632155

This allows clients to issue Tracing.start when tracing is already running, but
only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode,
as Tracing.start is currently the only way to specify it.

Committed: https://crrev.com/e886e3aeb93dd1786d6c3323a2cbd2aa8d99b407
Cr-Commit-Position: refs/heads/master@{#408301}
==========

[commit-bot: I haz the power, 2016-07-28 01:00:30]

Patchset 2 (id:??) landed as
https://crrev.com/e886e3aeb93dd1786d6c3323a2cbd2aa8d99b407
Cr-Commit-Position: refs/heads/master@{#408301}