Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

Issue 2189823002: Enable stream trace retrieval when start-up tracing is used (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: fixed typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
index 20bed39704c10568d533e7a5e106d05eaf48411b..ad068e162559309790a88b6003204bced76e3ae8 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
@@ -93,6 +93,7 @@ class TracingBackend(object):
self._TRACING_DOMAIN, self._NotificationHandler)
self._trace_events = []
self._is_tracing_running = is_tracing_running
+ self._start_issued = False
self._can_collect_data = False
self._has_received_all_tracing_data = False
self._support_modern_devtools_tracing_start_api = (
@@ -139,6 +140,7 @@ class TracingBackend(object):
'Tracing.start:\n' + json.dumps(response, indent=2))
self._is_tracing_running = True
+ self._start_issued = True
return True
def RecordClockSyncMarker(self, sync_id):
@@ -163,10 +165,22 @@ class TracingBackend(object):
if not self._trace_events:
raise TracingHasNotRunException()
else:
+ if not self._start_issued:
+ # Tracing is running but start was not issued so, startup tracing must
+ # be in effect. Issue another Tracing.start to update the transfer mode.
+ # TODO(caseq): get rid of it when streaming is the default.
+ params = {
+ 'transferMode': 'ReturnAsStream',
+ 'traceConfig': {}
+ }
+ req = {'method': 'Tracing.start', 'params': params}
+ self._inspector_websocket.SendAndIgnoreResponse(req)
+
req = {'method': 'Tracing.end'}
self._inspector_websocket.SendAndIgnoreResponse(req)
self._is_tracing_running = False
+ self._start_issued = False
self._can_collect_data = True
def DumpMemory(self, timeout=30):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698