Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2189463006: [interpreter] Put object in register for ToObject/ForInPrepare (Closed)

Created:
4 years, 4 months ago by klaasb
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Put object in register for ToObject/ForInPrepare This gets rid of the Star bytecodes that were always dispatched to from ToObject. ToObject now outputs to register instead of to the accumulator and ForInPrepare gets the receiver object from an input register. BUG=v8:4820 LOG=n Committed: https://crrev.com/26c17552424aec9db68f59f9658823d83f6986c9 Cr-Commit-Position: refs/heads/master@{#38177}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -65 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +11 lines, -14 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 4 chunks +8 lines, -12 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WideRegisters.golden View 2 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WithStatement.golden View 1 chunk +2 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-writer-unittest.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
klaasb
4 years, 4 months ago (2016-07-29 10:44:14 UTC) #8
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-07-29 10:56:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189463006/20001
4 years, 4 months ago (2016-07-29 11:13:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 11:14:59 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 11:18:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26c17552424aec9db68f59f9658823d83f6986c9
Cr-Commit-Position: refs/heads/master@{#38177}

Powered by Google App Engine
This is Rietveld 408576698