test/unittests/interpreter/bytecode-array-iterator-unittest.cc - Issue 2189463006: [interpreter] Put object in register for ToObject/ForInPrepare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

Issue 2189463006: [interpreter] Put object in register for ToObject/ForInPrepare (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/interpreter/bytecode-array-builder-unittest.cc ('k') | test/unittests/interpreter/bytecode-array-writer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

index 800e3d4991d29360da09e8ebd95b3518f12d29cb..cf34867d58c653916ce5ea194136efd2a53d20fa 100644

--- a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

@@ -55,7 +55,7 @@ TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

.BinaryOperation(Token::Value::ADD, reg_0)

.StoreAccumulatorInRegister(param)

.CallRuntimeForPair(Runtime::kLoadLookupSlotForCall, param, 1, reg_0)

- .ForInPrepare(reg_0)

+ .ForInPrepare(reg_0, reg_0)

.CallRuntime(Runtime::kLoadIC_Miss, reg_0, 1)

.Debugger()

.LoadGlobal(0x10000000, TypeofMode::NOT_INSIDE_TYPEOF)

@@ -239,7 +239,9 @@ TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

CHECK_EQ(iterator.current_offset(), offset);

CHECK_EQ(iterator.current_operand_scale(), OperandScale::kSingle);

CHECK_EQ(iterator.GetRegisterOperand(0).index(), reg_0.index());

- CHECK_EQ(iterator.GetRegisterOperandRange(0), 3);

+ CHECK_EQ(iterator.GetRegisterOperandRange(0), 1);

+ CHECK_EQ(iterator.GetRegisterOperand(1).index(), reg_0.index());

+ CHECK_EQ(iterator.GetRegisterOperandRange(1), 3);

CHECK(!iterator.done());

offset += Bytecodes::Size(Bytecode::kForInPrepare, OperandScale::kSingle);

iterator.Advance();