test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 2189463006: [interpreter] Put object in register for ToObject/ForInPrepare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2189463006: [interpreter] Put object in register for ToObject/ForInPrepare (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/WithStatement.golden ('k') | test/unittests/interpreter/bytecode-array-iterator-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index 93dd930e12a8bfdc672747832d74c429f3527618..f688da793e72e9f32852c07f7c2542abed129e65 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -181,7 +181,7 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

// Emit cast operator invocations.

builder.CastAccumulatorToNumber(reg)

- .CastAccumulatorToJSObject()

+ .CastAccumulatorToJSObject(reg)

.CastAccumulatorToName(reg);

// Emit control flow. Return must be the last instruction.

@@ -267,11 +267,11 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

BytecodeLabel after_rethrow;

builder.ReThrow().Bind(&after_rethrow);

- builder.ForInPrepare(reg)

+ builder.ForInPrepare(reg, reg)

.ForInDone(reg, reg)

.ForInNext(reg, reg, reg, 1)

.ForInStep(reg);

- builder.ForInPrepare(wide)

+ builder.ForInPrepare(reg, wide)

.ForInDone(reg, other)

.ForInNext(wide, wide, wide, 1024)

.ForInStep(reg);