Sent feedback reports must respect the product ID if any was provided

components/feedback/feedback_common.h

Index: components/feedback/feedback_common.h
diff --git a/components/feedback/feedback_common.h b/components/feedback/feedback_common.h
index fadb6bf38a4c6dee510e7b9784b3c3b3955520c2..dea86d23e91f4c63fa94e2aaa2b05356760be91d 100644
--- a/components/feedback/feedback_common.h
+++ b/components/feedback/feedback_common.h
@@ -65,6 +65,9 @@ class FeedbackCommon : public base::RefCountedThreadSafe<FeedbackCommon> {
   // CompressLogs() must have already been called.
   void PrepareReport(userfeedback::ExtensionSubmit* feedback_data) const;
 
+  // Returns true if a product ID was set in the feedback report.
+  bool HasProductId() const { return product_id_ != -1; }

[rkc, 2016/07/30 23:46:39]

Could this be private? We can always move the friend test to private also.

[afakhry, 2016/08/02 00:49:36]

Done.
I actually moved it to protected, just in case FeedbackData needs to check it?

[rkc, 2016/08/02 00:57:58]

If it does, we can move it to protected then :)
We should attempt to maintain the maximum encapsulation we can given the current
requirements of the code.

[afakhry, 2016/08/02 23:56:02]

Done.

+
   // Getters
   const std::string& category_tag() const { return category_tag_; }
   const std::string& page_url() const { return page_url_; }