chrome/common/extensions/api/feedback_private.idl - Issue 2189353003: Sent feedback reports must respect the product ID if any was provided

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/feedback_private.idl

Issue 2189353003: Sent feedback reports must respect the product ID if any was provided (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.cc ('k') | components/feedback/feedback_common.h » ('j') | components/feedback/feedback_common.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/feedback_private.idl

diff --git a/chrome/common/extensions/api/feedback_private.idl b/chrome/common/extensions/api/feedback_private.idl

index 2d6e4b3b1c9546baa7735fa8186b0ce96ce9d1cb..c16a6124485e7eb9fa241c19049f97eef3fe5066 100644

--- a/chrome/common/extensions/api/feedback_private.idl

+++ b/chrome/common/extensions/api/feedback_private.idl

@@ -48,7 +48,7 @@ namespace feedbackPrivate {

// Optional product ID to override the Chrome [OS] product id that is

// usually passed to the feedback server.

- DOMString? productId;

+ long? productId;

rkc 2016/07/30 23:46:39 Many, if not all, callers of the feedback UI set t

afakhry 2016/08/02 00:49:36 Thanks! As agreed, I added code to validate the ty

// Screenshot to send with this feedback.

[instanceOf=Blob] object? screenshot;