Sent feedback reports must respect the product ID if any was provided

components/feedback/feedback_common.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FEEDBACK_FEEDBACK_COMMON_H_
 #define COMPONENTS_FEEDBACK_FEEDBACK_COMMON_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 47 matching lines @@
   void AddLogs(std::unique_ptr<SystemLogsMap> logs);
   void CompressLogs();
 
   void AddFilesAndLogsToReport(
       userfeedback::ExtensionSubmit* feedback_data) const;
 
   // Fill in |feedback_data| with all the data that we have collected.
   // CompressLogs() must have already been called.
   void PrepareReport(userfeedback::ExtensionSubmit* feedback_data) const;
 
+  // Returns true if a product ID was set in the feedback report.
+  bool HasProductId() const { return product_id_ != -1; }

[rkc, 2016/07/30 23:46:39]

Could this be private? We can always move the friend test to private also.

[afakhry, 2016/08/02 00:49:36]

Done.
I actually moved it to protected, just in case FeedbackData needs to check it?

[rkc, 2016/08/02 00:57:58]

If it does, we can move it to protected then :)
We should attempt to maintain the maximum encapsulation we can given the current
requirements of the code.

[afakhry, 2016/08/02 23:56:02]

Done.

+
   // Getters
   const std::string& category_tag() const { return category_tag_; }
   const std::string& page_url() const { return page_url_; }
   const std::string& description() const { return description_; }
   const std::string& user_email() const { return user_email_; }
   const std::string* image() const { return image_.get(); }
   const SystemLogsMap* sys_info() const { return logs_.get(); }
   int32_t product_id() const { return product_id_; }
   std::string user_agent() const { return user_agent_; }
   std::string locale() const { return locale_; }
@@ skipping 40 matching lines @@
 
   // It is possible that multiple attachment add calls are running in
   // parallel, so synchronize access.
   base::Lock attachments_lock_;
   ScopedVector<AttachedFile> attachments_;
 
   std::unique_ptr<SystemLogsMap> logs_;
 };
 
 #endif  // COMPONENTS_FEEDBACK_FEEDBACK_COMMON_H_