Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2189113002: Rename CalledOnValidSequencedThread() to CalledOnValidSequence(). (Closed)

Created:
4 years, 4 months ago by fdoray
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tzik, posciak+watch_chromium.org, gavinp+memory_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kinuko+watch, shaktisahu+watch-blimp_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, android-webview-reviews_chromium.org, blink-worker-reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, nhiroki, feature-media-reviews_chromium.org, piman+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, michaeln, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, serviceworker-reviews, tommycli, kinuko+serviceworker, horo+watch_chromium.org, dtrainor+watch-blimp_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CalledOnValidSequencedThread() to CalledOnValidSequence(). The new name is more accurate (we don't verify that we're on a specific thread) and shorter. Discussion here: https://codereview.chromium.org/2165663003/diff/260001/base/sequence_checker.h#newcode25 TBR=jochen@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e2b19a106ba5144ceacaafb48128b2db395a6f22 Cr-Commit-Position: refs/heads/master@{#408558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -312 lines) Patch
M android_webview/browser/test/fake_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/id_map.h View 9 chunks +16 lines, -16 lines 0 comments Download
M base/memory/weak_ptr.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sequence_checker.h View 3 chunks +3 lines, -5 lines 0 comments Download
M base/sequence_checker_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sequence_checker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sequence_checker_unittest.cc View 10 chunks +42 lines, -56 lines 0 comments Download
M base/threading/sequenced_task_runner_handle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/threading/thread.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M blimp/net/thread_pipe_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/image_decoder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_path_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_wrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc View 10 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_change_processor_on_worker.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_change_processor_wrapper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 30 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/task_management/sampling/task_group_sampler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_store_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_usage_store.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/db_data_owner.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/notifications/notification_database.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M net/ssl/ssl_key_logger.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/quota/open_file_handle.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/quota/open_file_handle_context.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/quota/quota_reservation.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/quota/quota_reservation_buffer.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/quota/quota_reservation_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
fdoray
danakj@: Can you review base/ and storage/?
4 years, 4 months ago (2016-07-28 18:29:14 UTC) #3
danakj
I agree that's a better name, thanks. LGTM
4 years, 4 months ago (2016-07-28 18:47:44 UTC) #4
fdoray
agl@chromium.org: Please review changes in net/ chcunningham@chromium.org: Please review changes in media/ boliu@chromium.org: Please review ...
4 years, 4 months ago (2016-07-28 21:32:16 UTC) #6
fdoray
agl@chromium.org: Please review changes in net/ chcunningham@chromium.org: Please review changes in media/ boliu@chromium.org: Please review ...
4 years, 4 months ago (2016-07-28 21:33:23 UTC) #8
nyquist
on behalf of dtrainor, blimp/ lgtm
4 years, 4 months ago (2016-07-28 21:34:56 UTC) #10
boliu
On 2016/07/28 21:32:16, fdoray wrote: > mailto:agl@chromium.org: Please review changes in net/ > > mailto:chcunningham@chromium.org: ...
4 years, 4 months ago (2016-07-28 21:35:18 UTC) #11
Lei Zhang
On 2016/07/28 21:33:23, fdoray wrote: > mailto:jochen@chromium.org: Please review changes in chrome/ chrome/ lgtm
4 years, 4 months ago (2016-07-28 21:39:08 UTC) #12
agl
lgtm
4 years, 4 months ago (2016-07-28 21:47:49 UTC) #13
chcunningham
media lgtm
4 years, 4 months ago (2016-07-28 22:31:05 UTC) #14
no sievers
gpu lgtm
4 years, 4 months ago (2016-07-28 22:34:49 UTC) #15
piman
gpu/ LGTM
4 years, 4 months ago (2016-07-28 22:35:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189113002/1
4 years, 4 months ago (2016-07-29 00:37:06 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 02:30:32 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 02:32:41 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2b19a106ba5144ceacaafb48128b2db395a6f22
Cr-Commit-Position: refs/heads/master@{#408558}

Powered by Google App Engine
This is Rietveld 408576698