components/data_reduction_proxy/core/browser/data_store_impl.cc - Issue 2189113002: Rename CalledOnValidSequencedThread() to CalledOnValidSequence().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_store_impl.cc

Issue 2189113002: Rename CalledOnValidSequencedThread() to CalledOnValidSequence(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/sampling/task_group_sampler.cc ('k') | components/data_reduction_proxy/core/browser/data_usage_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_store_impl.cc

diff --git a/components/data_reduction_proxy/core/browser/data_store_impl.cc b/components/data_reduction_proxy/core/browser/data_store_impl.cc

index fc269e27aa923a933b984dc14bfc13c290894aef..76903bee1dfa8bb9b940173a9050e6c2f1064342 100644

--- a/components/data_reduction_proxy/core/browser/data_store_impl.cc

+++ b/components/data_reduction_proxy/core/browser/data_store_impl.cc

@@ -47,11 +47,11 @@ DataStoreImpl::DataStoreImpl(const base::FilePath& profile_path)

}

DataStoreImpl::~DataStoreImpl() {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

}

void DataStoreImpl::InitializeOnDBThread() {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

DCHECK(!db_);

DataStore::Status status = OpenDB();

@@ -61,7 +61,7 @@ void DataStoreImpl::InitializeOnDBThread() {

DataStore::Status DataStoreImpl::Get(base::StringPiece key,

std::string* value) {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

if (!db_)

return MISC_ERROR;

@@ -78,7 +78,7 @@ DataStore::Status DataStoreImpl::Get(base::StringPiece key,

DataStore::Status DataStoreImpl::Put(

const std::map<std::string, std::string>& map) {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

if (!db_)

return MISC_ERROR;

@@ -97,7 +97,7 @@ DataStore::Status DataStoreImpl::Put(

}

DataStore::Status DataStoreImpl::Delete(base::StringPiece key) {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

if (!db_)

return MISC_ERROR;

@@ -112,7 +112,7 @@ DataStore::Status DataStoreImpl::Delete(base::StringPiece key) {

}

DataStore::Status DataStoreImpl::OpenDB() {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

leveldb::Options options;

options.create_if_missing = true;

@@ -145,7 +145,7 @@ DataStore::Status DataStoreImpl::OpenDB() {

}

void DataStoreImpl::RecreateDB() {

- DCHECK(sequence_checker_.CalledOnValidSequencedThread());

+ DCHECK(sequence_checker_.CalledOnValidSequence());

LOG(WARNING) << "Deleting corrupt Data Reduction Proxy LevelDB";

db_.reset(nullptr);