Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4112)

Unified Diff: base/threading/thread.h

Issue 2189113002: Rename CalledOnValidSequencedThread() to CalledOnValidSequence(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/sequenced_worker_pool_unittest.cc ('k') | base/threading/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread.h
diff --git a/base/threading/thread.h b/base/threading/thread.h
index 45064240d76f8436ceb7ab51ff205be4646a8485..ac48849a9565b6dc02828aaf32e7ef594df5f5ef 100644
--- a/base/threading/thread.h
+++ b/base/threading/thread.h
@@ -178,7 +178,7 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
// external synchronization catches the unsynchronized effects of Start().
// TODO(gab): Despite all of the above this test has to be disabled for now
// per crbug.com/629139#c6.
- // DCHECK(owning_sequence_checker_.CalledOnValidSequencedThread() ||
+ // DCHECK(owning_sequence_checker_.CalledOnValidSequence() ||
// id_ == PlatformThread::CurrentId() || message_loop_)
// << id_ << " vs " << PlatformThread::CurrentId();
return message_loop_;
@@ -194,7 +194,7 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
// called from the underlying thread itself.
scoped_refptr<SingleThreadTaskRunner> task_runner() const {
// Refer to the DCHECK and comment inside |message_loop()|.
- DCHECK(owning_sequence_checker_.CalledOnValidSequencedThread() ||
+ DCHECK(owning_sequence_checker_.CalledOnValidSequence() ||
id_ == PlatformThread::CurrentId() || message_loop_)
<< id_ << " vs " << PlatformThread::CurrentId();
return message_loop_ ? message_loop_->task_runner() : nullptr;
@@ -229,7 +229,7 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
static bool GetThreadWasQuitProperly();
void set_message_loop(MessageLoop* message_loop) {
- DCHECK(owning_sequence_checker_.CalledOnValidSequencedThread());
+ DCHECK(owning_sequence_checker_.CalledOnValidSequence());
message_loop_ = message_loop;
}
« no previous file with comments | « base/threading/sequenced_worker_pool_unittest.cc ('k') | base/threading/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698