Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2188743003: Fix Gamma enum in DstColorSpace metric (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@histogram
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Gamma enum in DstColorSpace metric This puts us in sync with histograms.xml. The previous CL was buggy in that the enums weren't synced. https://codereview.chromium.org/2177933002/ BUG= Committed: https://crrev.com/ca48b3108b02b791712245cfa97bf6b198b0a09c Cr-Commit-Position: refs/heads/master@{#408171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
msarett
We've started getting data! https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial But we should never hit the kFail bucket. And once ...
4 years, 4 months ago (2016-07-27 16:17:43 UTC) #5
f(malita)
lgtm
4 years, 4 months ago (2016-07-27 16:19:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188743003/1
4 years, 4 months ago (2016-07-27 17:38:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:42:38 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:45:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca48b3108b02b791712245cfa97bf6b198b0a09c
Cr-Commit-Position: refs/heads/master@{#408171}

Powered by Google App Engine
This is Rietveld 408576698