Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2190653004: Add more detail to Dst Color Space UMA (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
f(malita), Steven Holte
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), asvitkine+watch_chromium.org, blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@histogram2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more detail to Dst Color Space UMA First version was good: https://codereview.chromium.org/2177933002/ Hoping to add to more detail to better understand "non-standard" gammas. BUG= Committed: https://crrev.com/1d6121b774ae25497a1f057e396b0d6b6c13bdaf Cr-Commit-Position: refs/heads/master@{#408420}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use a switch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp View 1 1 chunk +34 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
msarett
I'm iterating on this a bit to try to further break down the categories that ...
4 years, 4 months ago (2016-07-27 20:27:39 UTC) #2
f(malita)
https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp (right): https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp#newcode47 third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp:47: } else if (SkColorSpace::kInvalid_GammaNamed == skGamma) { Does this ...
4 years, 4 months ago (2016-07-27 20:46:42 UTC) #3
msarett
Yes it does. Sorry I was trying to get ahead of the game. Obviously this ...
4 years, 4 months ago (2016-07-27 20:49:02 UTC) #4
Steven Holte
histograms.xml lgtm
4 years, 4 months ago (2016-07-27 20:51:13 UTC) #5
f(malita)
platform/graphics LGTM https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp (right): https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp#newcode41 third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp:41: if (SkColorSpace::kLinear_GammaNamed == skGamma) { Nit: it's ...
4 years, 4 months ago (2016-07-27 20:56:44 UTC) #6
msarett
Thanks a lot to you both for the fast reviews! https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp (right): https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp#newcode41 ...
4 years, 4 months ago (2016-07-27 21:05:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190653004/20001
4 years, 4 months ago (2016-07-28 15:54:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 17:31:15 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:34:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d6121b774ae25497a1f057e396b0d6b6c13bdaf
Cr-Commit-Position: refs/heads/master@{#408420}

Powered by Google App Engine
This is Rietveld 408576698