Add more detail to Dst Color Space UMA

Add more detail to Dst Color Space UMA

First version was good:
https://codereview.chromium.org/2177933002/

Hoping to add to more detail to better understand "non-standard"
gammas.

BUG=

Committed: https://crrev.com/1d6121b774ae25497a1f057e396b0d6b6c13bdaf
Cr-Commit-Position: refs/heads/master@{#408420}

[msarett, 2016-07-27 20:27:38]

msarett@google.com changed reviewers:
+ fmalita@chromium.org, holte@chromium.org

[msarett, 2016-07-27 20:27:39]

I'm iterating on this a bit to try to further break down
the categories that we don't completely understand yet.

[f(malita), 2016-07-27 20:46:42]

https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp (right):

https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp:47: } else if
(SkColorSpace::kInvalid_GammaNamed == skGamma) {
Does this depend on a Skia CL? I can't find SkColorSpace::kInvalid_GammaNamed
locally.

[msarett, 2016-07-27 20:49:02]

Yes it does.  Sorry I was trying to get ahead of the game.  Obviously this can't
land until we roll.
https://codereview.chromium.org/2188633003/#

[Steven Holte, 2016-07-27 20:51:13]

histograms.xml lgtm

[f(malita), 2016-07-27 20:56:44]

platform/graphics LGTM

https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp (right):

https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp:41: if
(SkColorSpace::kLinear_GammaNamed == skGamma) {
Nit: it's a matter a taste (so feel free to ignore:), but I think this would
look less repetitive as a switch statement.

[msarett, 2016-07-27 21:05:17]

Thanks a lot to you both for the fast reviews!

https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp (right):

https://codereview.chromium.org/2190653004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp:41: if
(SkColorSpace::kLinear_GammaNamed == skGamma) {
On 2016/07/27 20:56:44, f(malita) wrote:
> Nit: it's a matter a taste (so feel free to ignore:), but I think this would
> look less repetitive as a switch statement.

Yes agreed!  I think that looks better.

[msarett, 2016-07-28 15:53:48]

The CQ bit was checked by msarett@google.com

[msarett, 2016-07-28 15:53:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2190653004/#ps20001
(title: "Use a switch")

[commit-bot: I haz the power, 2016-07-28 15:54:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 17:31:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 17:34:54]

Description was changed from

==========
Add more detail to Dst Color Space UMA

First version was good:
https://codereview.chromium.org/2177933002/

Hoping to add to more detail to better understand "non-standard"
gammas.

BUG=
==========

to

==========
Add more detail to Dst Color Space UMA

First version was good:
https://codereview.chromium.org/2177933002/

Hoping to add to more detail to better understand "non-standard"
gammas.

BUG=

Committed: https://crrev.com/1d6121b774ae25497a1f057e396b0d6b6c13bdaf
Cr-Commit-Position: refs/heads/master@{#408420}
==========

[commit-bot: I haz the power, 2016-07-28 17:34:55]

Patchset 2 (id:??) landed as
https://crrev.com/1d6121b774ae25497a1f057e396b0d6b6c13bdaf
Cr-Commit-Position: refs/heads/master@{#408420}